From 8237b64a3bc48619e8c9e08e4b0fcfb8940e8815 Mon Sep 17 00:00:00 2001
From: Joren Broekema <joren.broekema@ing.com>
Date: Wed, 23 Oct 2019 17:11:54 +0200
Subject: [PATCH] fix(overlays): remove setting inheritsReferenceWidth by
 default

---
 packages/overlays/src/OverlayController.js       |  6 ++++--
 packages/overlays/test/local-positioning.test.js | 12 ++++++------
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/packages/overlays/src/OverlayController.js b/packages/overlays/src/OverlayController.js
index e3f2be79d..a72e66259 100644
--- a/packages/overlays/src/OverlayController.js
+++ b/packages/overlays/src/OverlayController.js
@@ -26,7 +26,7 @@ export class OverlayController {
       invokerNode: config.invokerNode,
       referenceNode: null,
       elementToFocusAfterHide: document.body,
-      inheritsReferenceWidth: 'min',
+      inheritsReferenceWidth: '',
       hasBackdrop: false,
       isBlocking: false,
       preventsScroll: false,
@@ -498,8 +498,10 @@ export class OverlayController {
       case 'full':
         this._contentNodeWrapper.style.width = referenceWidth;
         break;
-      default:
+      case 'min':
         this._contentNodeWrapper.style.minWidth = referenceWidth;
+        break;
+      /* no default */
     }
   }
 
diff --git a/packages/overlays/test/local-positioning.test.js b/packages/overlays/test/local-positioning.test.js
index 3f2623b38..fe8ad1d38 100644
--- a/packages/overlays/test/local-positioning.test.js
+++ b/packages/overlays/test/local-positioning.test.js
@@ -202,14 +202,14 @@ describe('Local Positioning', () => {
       `);
       await ctrl.show();
       expect(normalizeTransformStyle(ctrl.content.style.transform)).to.equal(
-        'translate3d(0px, -28px, 0px)',
+        'translate3d(10px, -28px, 0px)',
         'Popper positioning values',
       );
 
       await ctrl.hide();
       await ctrl.show();
       expect(normalizeTransformStyle(ctrl.content.style.transform)).to.equal(
-        'translate3d(0px, -28px, 0px)',
+        'translate3d(10px, -28px, 0px)',
         'Popper positioning values should be identical after hiding and showing',
       );
     });
@@ -242,7 +242,7 @@ describe('Local Positioning', () => {
 
       await ctrl.show();
       expect(normalizeTransformStyle(ctrl.content.style.transform)).to.equal(
-        'translate3d(0px, -30px, 0px)',
+        'translate3d(10px, -30px, 0px)',
         'Popper positioning values',
       );
 
@@ -258,7 +258,7 @@ describe('Local Positioning', () => {
       await ctrl.show();
       expect(ctrl._popper.options.modifiers.offset.offset).to.equal('0, 20px');
       expect(normalizeTransformStyle(ctrl.content.style.transform)).to.equal(
-        'translate3d(0px, -40px, 0px)',
+        'translate3d(10px, -40px, 0px)',
         'Popper positioning Y value should be 10 less than previous, due to the added extra 10px offset',
       );
     });
@@ -292,7 +292,7 @@ describe('Local Positioning', () => {
 
       await ctrl.show();
       expect(normalizeTransformStyle(ctrl.content.style.transform)).to.equal(
-        'translate3d(0px, -30px, 0px)',
+        'translate3d(10px, -30px, 0px)',
         'Popper positioning values',
       );
 
@@ -305,7 +305,7 @@ describe('Local Positioning', () => {
         },
       });
       expect(normalizeTransformStyle(ctrl.content.style.transform)).to.equal(
-        'translate3d(0px, -40px, 0px)',
+        'translate3d(10px, -40px, 0px)',
         'Popper positioning Y value should be 10 less than previous, due to the added extra 10px offset',
       );
     });