From 7e02c39a0fe9fa3b44136c86ef34d45ad8d190ff Mon Sep 17 00:00:00 2001 From: Thomas Allmer Date: Fri, 11 Sep 2020 12:39:30 +0200 Subject: [PATCH] fix(select-rich): remove usage of public class fields --- .changeset/friendly-tables-pretend.md | 5 +++++ packages/select-rich/src/LionSelectRich.js | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 .changeset/friendly-tables-pretend.md diff --git a/.changeset/friendly-tables-pretend.md b/.changeset/friendly-tables-pretend.md new file mode 100644 index 000000000..753faa0e8 --- /dev/null +++ b/.changeset/friendly-tables-pretend.md @@ -0,0 +1,5 @@ +--- +'@lion/select-rich': patch +--- + +Remove public class field usage in Select Rich diff --git a/packages/select-rich/src/LionSelectRich.js b/packages/select-rich/src/LionSelectRich.js index d6eb8c03f..87686c758 100644 --- a/packages/select-rich/src/LionSelectRich.js +++ b/packages/select-rich/src/LionSelectRich.js @@ -101,6 +101,7 @@ export class LionSelectRich extends SlotMixin(ScopedElementsMixin(OverlayMixin(L this.__invokerOnClick = this.__invokerOnClick.bind(this); this.__overlayBeforeShow = this.__overlayBeforeShow.bind(this); this.__focusInvokerOnLabelClick = this.__focusInvokerOnLabelClick.bind(this); + this._listboxOnClick = this._listboxOnClick.bind(this); } connectedCallback() { @@ -412,9 +413,9 @@ export class LionSelectRich extends SlotMixin(ScopedElementsMixin(OverlayMixin(L } } - _listboxOnClick = () => { + _listboxOnClick() { this.opened = false; - }; + } _setupListboxNodeInteractions() { super._setupListboxNodeInteractions();