ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(field): getAriaElementsInRightDomOrder IE fix

Browse source
This commit is contained in:
Thijs Louisse 2019-11-27 13:29:40 +01:00
parent 708b6f991d
commit 76492af889
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/field/src/utils/getAriaElementsInRightDomOrder.js
View file

@ -1,3 +1,5 @@
const isIE11 = /Trident/.test(window.navigator.userAgent);
/** /**
* @desc Let the order of adding ids to aria element by DOM order, so that the screen reader * @desc Let the order of adding ids to aria element by DOM order, so that the screen reader
* respects visual order when reading: * respects visual order when reading:
@ -5,16 +7,16 @@
* @param {array} descriptionElements - holds references to description or label elements whose * @param {array} descriptionElements - holds references to description or label elements whose
* id should be returned * id should be returned
* @returns {array} sorted set of elements based on dom order * @returns {array} sorted set of elements based on dom order
*
*/ */
export function getAriaElementsInRightDomOrder(descriptionElements, { reverse } = {}) { export function getAriaElementsInRightDomOrder(descriptionElements, { reverse } = {}) {
const putPrecedingSiblingsAndLocalParentsFirst = (a, b) => { const putPrecedingSiblingsAndLocalParentsFirst = (a, b) => {
// https://developer.mozilla.org/en-US/docs/Web/API/Node/compareDocumentPosition // https://developer.mozilla.org/en-US/docs/Web/API/Node/compareDocumentPosition
const pos = a.compareDocumentPosition(b); const pos = a.compareDocumentPosition(b);
// Unfortunately, for IE, we have to switch the order (?)
if (pos === Node.DOCUMENT_POSITION_PRECEDING || pos === Node.DOCUMENT_POSITION_CONTAINED_BY) { if (pos === Node.DOCUMENT_POSITION_PRECEDING || pos === Node.DOCUMENT_POSITION_CONTAINED_BY) {
return 1; return isIE11 ? -1 : 1;
} }
return -1; return isIE11 ? 1 : -1;
}; };
const descriptionEls = descriptionElements.filter(el => el); // filter out null references const descriptionEls = descriptionElements.filter(el => el); // filter out null references