ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: allow tests to run w/o polyfill

Browse source 
Co-authored-by: aghArdeshir <ardeshirizadinl@gmail.com>
This commit is contained in:
Thijs Louisse 2024-11-10 11:05:14 +01:00 committed by Thijs Louisse
parent 510f8b931f
commit 6da73f7a36
2 changed files with 20 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
packages/ui/components/core/test/SlotMixin.test.js
View file

@ -1,31 +1,14 @@
import sinon from 'sinon';
import { defineCE, expect, fixture, fixtureSync, unsafeStatic, html } from '@open-wc/testing';
import { ScopedElementsMixin } from '@open-wc/scoped-elements/lit-element.js';
import { SlotMixin } from '@lion/ui/core.js';
import { LitElement } from 'lit';
import sinon from 'sinon';
import { ScopedElementsMixin, supportsScopedRegistry } from '../src/ScopedElementsMixin.js';
/**
* @typedef {import('../types/SlotMixinTypes.js').SlotHost} SlotHost
*/
// @ts-ignore
const createElementNative = ShadowRoot.prototype.createElement;
function mockScopedRegistry() {
const outputObj = { createElementCallCount: 0 };
// @ts-expect-error wait for browser support
ShadowRoot.prototype.createElement = (tagName, options) => {
outputObj.createElementCallCount += 1;
// Return an element that lit can use as render target
return createElementNative(tagName, options);
};
return outputObj;
}
function unMockScopedRegistry() {
// @ts-expect-error wait for browser support
ShadowRoot.prototype.createElement = createElementNative;
}
describe('SlotMixin', () => {
it('inserts provided element into light dom and sets slot', async () => {
const tag = defineCE(
@ -568,8 +551,11 @@ describe('SlotMixin', () => {
});
describe('Scoped Registries', () => {
it('supports scoped elements when polyfill loaded', async () => {
const outputObj = mockScopedRegistry();
it('supports scoped elements when scoped registries supported (or polyfill loaded)', async () => {
if (!supportsScopedRegistry()) return;
// @ts-expect-error
const createElSpy = sinon.spy(ShadowRoot.prototype, 'createElement');
class ScopedEl extends LitElement {}
@ -600,14 +586,14 @@ describe('SlotMixin', () => {
const tag = unsafeStatic(tagName);
await fixture(html`<${tag}></${tag}>`);
expect(outputObj.createElementCallCount).to.equal(1);
expect(createElSpy.callCount).to.equal(1);
unMockScopedRegistry();
createElSpy.restore();
});
it('does not scope elements when polyfill not loaded', async () => {
// @ts-expect-error
ShadowRoot.prototype.createElement = null;
it('does not scope elements when scoped registries not supported (or polyfill not loaded)', async () => {
if (supportsScopedRegistry()) return;
class ScopedEl extends LitElement {}
const tagName = defineCE(
@ -645,7 +631,6 @@ describe('SlotMixin', () => {
document.body.removeChild(renderTarget);
docSpy.restore();
unMockScopedRegistry();
});
});
});

14
packages/ui/components/form-core/test-suites/ValidateMixin.suite.js
View file

@ -2,25 +2,25 @@ import { LitElement } from 'lit';
import { aTimeout, defineCE, expect, fixture, html, unsafeStatic } from '@open-wc/testing';
import {
getFormControlMembers,
AlwaysInvalid,
AlwaysValid,
AsyncAlwaysInvalid,
AsyncAlwaysValid,
AlwaysInvalid,
AlwaysValid,
} from '@lion/ui/form-core-test-helpers.js';
import sinon from 'sinon';
import {
ResultValidator,
ValidateMixin,
EqualsLength,
Unparseable,
MaxLength,
MinLength,
Required,
ResultValidator,
Unparseable,
ValidateMixin,
Validator,
Required,
} from '@lion/ui/form-core.js';
import '@lion/ui/define/lion-field.js';
import '@lion/ui/define/lion-validation-feedback.js';
import '@lion/ui/define/lion-field.js';
/**
* @typedef {import('@lion/ui/form-core.js').LionField} LionField