ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1151 from ing-bank/fix/dialogSendMultipleOpenedChangedEvent

Browse source 
fix(dialog): prevent opened-changed to be sent when it is not changing
This commit is contained in:
gerjanvangeest 2020-12-21 06:55:45 +01:00 committed by GitHub
commit 679d189ec4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/silver-horses-return.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/overlays': patch
---
Prevent `opened-changed` event to be sent twice

2
packages/overlays/src/OverlayMixin.js
View file

@ -62,7 +62,7 @@ export const OverlayMixinImplementation = superclass =>
*/ */
requestUpdateInternal(name, oldValue) { requestUpdateInternal(name, oldValue) {
super.requestUpdateInternal(name, oldValue); super.requestUpdateInternal(name, oldValue);
if (name === 'opened') { if (name === 'opened' && this.opened !== oldValue) {
this.dispatchEvent(new Event('opened-changed')); this.dispatchEvent(new Event('opened-changed'));
} }
} }

3
packages/overlays/test-suites/OverlayMixin.suite.js
View file

@ -132,6 +132,9 @@ export function runOverlayMixinSuite({ tagString, tag, suffix = '' }) {
await el.updateComplete; await el.updateComplete;
expect(spy.callCount).to.equal(1); expect(spy.callCount).to.equal(1);
expect(el.opened).to.be.true; expect(el.opened).to.be.true;
el.opened = true;
await el.updateComplete;
expect(spy.callCount).to.equal(1);
await el._overlayCtrl.hide(); await el._overlayCtrl.hide();
await el.updateComplete; await el.updateComplete;
expect(spy.callCount).to.equal(2); expect(spy.callCount).to.equal(2);