From 66c5f2cd3688e7b93ba865658a2c4200de1b411a Mon Sep 17 00:00:00 2001 From: Joren Broekema Date: Wed, 30 Sep 2020 17:42:49 +0200 Subject: [PATCH] feat(select): add types --- .changeset/tender-cows-allow.md | 5 +++++ packages/select/src/LionSelect.js | 2 -- packages/select/test/lion-select.test.js | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 .changeset/tender-cows-allow.md diff --git a/.changeset/tender-cows-allow.md b/.changeset/tender-cows-allow.md new file mode 100644 index 000000000..0e1a25573 --- /dev/null +++ b/.changeset/tender-cows-allow.md @@ -0,0 +1,5 @@ +--- +'@lion/select': minor +--- + +Add types for select package. diff --git a/packages/select/src/LionSelect.js b/packages/select/src/LionSelect.js index 8a5303d33..91af142cd 100644 --- a/packages/select/src/LionSelect.js +++ b/packages/select/src/LionSelect.js @@ -27,8 +27,6 @@ import { LionField } from '@lion/form-core'; * @customElement lion-select * @extends {LionField} */ - -// eslint-disable-next-line no-unused-vars export class LionSelect extends LionField { connectedCallback() { super.connectedCallback(); diff --git a/packages/select/test/lion-select.test.js b/packages/select/test/lion-select.test.js index 7048fcae9..051da441c 100644 --- a/packages/select/test/lion-select.test.js +++ b/packages/select/test/lion-select.test.js @@ -13,7 +13,7 @@ describe('lion-select', () => { `); - expect(lionSelect.querySelector('select').value).to.equal('nr2'); + expect(lionSelect.querySelector('select')?.value).to.equal('nr2'); }); it('is accessible', async () => {