From 6321777ec7eb7f95f1b60d4d48e51a62d85eaf15 Mon Sep 17 00:00:00 2001 From: Mikhail Bashkirov Date: Wed, 17 Jul 2019 12:27:11 +0200 Subject: [PATCH] chore(localize): remove side effects between tests --- packages/localize/test-helpers.js | 2 ++ packages/localize/test/LocalizeMixin.test.js | 14 ++++---------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/packages/localize/test-helpers.js b/packages/localize/test-helpers.js index 90f262776..ea1a85e10 100644 --- a/packages/localize/test-helpers.js +++ b/packages/localize/test-helpers.js @@ -2,6 +2,8 @@ import { localize } from './src/localize.js'; export const localizeTearDown = () => { // makes sure that between tests the localization is reset to default state + localize._teardownHtmlLangAttributeObserver(); document.documentElement.lang = 'en-GB'; + localize._setupHtmlLangAttributeObserver(); localize.reset(); }; diff --git a/packages/localize/test/LocalizeMixin.test.js b/packages/localize/test/LocalizeMixin.test.js index c64db5ea4..059b9ac35 100644 --- a/packages/localize/test/LocalizeMixin.test.js +++ b/packages/localize/test/LocalizeMixin.test.js @@ -18,20 +18,14 @@ import { } from './test-utils.js'; import { localize } from '../src/localize.js'; +import { localizeTearDown } from '../test-helpers.js'; import { LocalizeMixin } from '../src/LocalizeMixin.js'; -const reset = () => { - resetFakeImport(); - // makes sure that between tests the localization is reset to default state - document.documentElement.lang = 'en-GB'; - localize.reset(); -}; - describe('LocalizeMixin', () => { - reset(); - afterEach(async () => { - reset(); + afterEach(() => { + resetFakeImport(); + localizeTearDown(); }); it('loads namespaces defined in "get localizeNamespaces()" when created before attached to DOM', async () => {