From 5ad98a26fa39d1c2e593023bb188d30192843c27 Mon Sep 17 00:00:00 2001 From: Thijs Louisse Date: Tue, 7 Jun 2022 22:38:13 +0200 Subject: [PATCH] fix(core): use partial renderOptions in SlotMixin (for Safari) --- .changeset/grumpy-donkeys-camp.md | 5 +++++ packages/core/src/SlotMixin.js | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .changeset/grumpy-donkeys-camp.md diff --git a/.changeset/grumpy-donkeys-camp.md b/.changeset/grumpy-donkeys-camp.md new file mode 100644 index 000000000..d1c65770b --- /dev/null +++ b/.changeset/grumpy-donkeys-camp.md @@ -0,0 +1,5 @@ +--- +'@lion/core': patch +--- + +fix: use partial renderOptions in SlotMixin (for Safari) diff --git a/packages/core/src/SlotMixin.js b/packages/core/src/SlotMixin.js index c2b0a1883..452664885 100644 --- a/packages/core/src/SlotMixin.js +++ b/packages/core/src/SlotMixin.js @@ -44,7 +44,9 @@ const SlotMixinImplementation = superclass => const registryRoot = supportsScopedRegistry ? this.shadowRoot : document; // @ts-expect-error wait for browser support const tempRenderTarget = registryRoot.createElement('div'); - render(template, tempRenderTarget, this.renderOptions); + // Providing all options breaks Safari; keep host and creationScope + const { creationScope, host } = this.renderOptions; + render(template, tempRenderTarget, { creationScope, host }); return Array.from(tempRenderTarget.childNodes); }