diff --git a/packages/ajax/src/AjaxClass.js b/packages/ajax/src/AjaxClass.js index 35b9a3fcc..345ed1616 100644 --- a/packages/ajax/src/AjaxClass.js +++ b/packages/ajax/src/AjaxClass.js @@ -75,7 +75,6 @@ export class AjaxClass extends LionSingleton { /** * Sets the config for the instance - * TODO: rename to 'config', because of conflict with options() request method on axios */ set options(config) { this.__config = config; @@ -130,7 +129,6 @@ export class AjaxClass extends LionSingleton { * @param {string} url the endpoint location * @param {AxiosRequestConfig} config the config specific for this request * @returns {AxiosResponseSchema} - * TODO: consider reenable after rename of options to config */ // options(url, config) { // return this.proxy.options.apply(this, [url, { ...this.__config, ...config }]); diff --git a/packages/button/test/lion-button.test.js b/packages/button/test/lion-button.test.js index 8c43082d2..cec060e31 100644 --- a/packages/button/test/lion-button.test.js +++ b/packages/button/test/lion-button.test.js @@ -47,7 +47,6 @@ describe('lion-button', () => { it('hides the native button in the UI', async () => { const el = await fixture(`foo`); expect(el._nativeButtonNode.getAttribute('tabindex')).to.equal('-1'); - // TODO: If we abstract to an srOnlyMixin, we should test that the styling equals that of the srOnlyMixin output expect(window.getComputedStyle(el._nativeButtonNode).clip).to.equal('rect(0px, 0px, 0px, 0px)'); }); diff --git a/packages/calendar/src/utils/dayTemplate.js b/packages/calendar/src/utils/dayTemplate.js index a8f7a0b97..d7442744f 100644 --- a/packages/calendar/src/utils/dayTemplate.js +++ b/packages/calendar/src/utils/dayTemplate.js @@ -15,7 +15,6 @@ const defaultMonthLabels = [ 'December', ]; -// TODO: remove as much logic as possible from this template and move to processor export function dayTemplate(day, { weekdays, monthsLabels = defaultMonthLabels } = {}) { const dayNumber = day.date.getDate(); const monthName = monthsLabels[day.date.getMonth()]; diff --git a/packages/field/README.md b/packages/field/README.md index f2080806e..e3031f50b 100644 --- a/packages/field/README.md +++ b/packages/field/README.md @@ -53,13 +53,8 @@ Fieldsets are the basis for: ## Other Resources - - - - [Model Value](./docs/modelValue.md) - [Formatting and parsing](./docs/FormattingAndParsing.md) - [Interaction states](./docs/InteractionStates.md) - [Validation System](../validate/docs/ValidationSystem.md) - [Custom Fields](./docs/CustomFieldsTutorial.md) - - diff --git a/packages/field/docs/FormFundaments.md b/packages/field/docs/FormFundaments.md index b183d173d..3cec7713a 100644 --- a/packages/field/docs/FormFundaments.md +++ b/packages/field/docs/FormFundaments.md @@ -50,13 +50,8 @@ Fieldsets are the basis for: ## Other Resources - - - - [Model Value](./modelValue.md) - [Formatting and parsing](./FormattingAndParsing.md) - [Interaction states](./InteractionStates.md) - [Validation System](../../validate/docs/ValidationSystem.md) - [FieldCustomMixin](./FieldCustomMixin.md) - - diff --git a/packages/field/src/FormControlMixin.js b/packages/field/src/FormControlMixin.js index 8133e6ae3..c58717615 100644 --- a/packages/field/src/FormControlMixin.js +++ b/packages/field/src/FormControlMixin.js @@ -393,9 +393,6 @@ export const FormControlMixin = dedupeMixin( * with the CSS component. * Note that every occurence of '::slotted(*)' can be rewritten to '> *' for use in an other * context - * - * TODO: find best naming convention: https://en.bem.info/methodology/naming-convention/ - * (react style would align better with JSS) */ /** @@ -418,6 +415,8 @@ export const FormControlMixin = dedupeMixin( * - {state} [dirty] whether the value has changed since initial value * * TODO: update states below + * These classes are now attributes. Check them agains the new attribute names inside ValidateMixin + * and InteractionStateMixin. Some states got renamed. Make sure to use the correct ones! * - {state} .state-focused: when .form-control (,