ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #989 from ing-bank/fix/scrollTargetNode

Browse source 
fix(select-rich): change scrollTargetNode to listboxNode
This commit is contained in:
Joren Broekema 2020-10-05 18:07:38 +02:00 committed by GitHub
commit 580603cedf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/stupid-ads-guess.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/select-rich': patch
---
Change scrollTargetNode to listboxNode, same as parent and extention layer. The extention layer has a different overlayContentNode and had to set it back to listboxNode.

2
packages/select-rich/src/LionSelectRich.js
View file

@ -63,7 +63,7 @@ export class LionSelectRich extends SlotMixin(ScopedElementsMixin(OverlayMixin(L
} }
get _scrollTargetNode() { get _scrollTargetNode() {
return this._overlayContentNode._scrollTargetNode || this._overlayContentNode; return this._listboxNode._scrollTargetNode || this._listboxNode;
} }
get checkedIndex() { get checkedIndex() {