From 56cc174c0be55db54b16ddc3b21dcba4bb71e53e Mon Sep 17 00:00:00 2001 From: Joren Broekema Date: Thu, 24 Sep 2020 18:34:06 +0200 Subject: [PATCH] fix(tabs): clear slottable store properly on slotchange --- .changeset/rotten-dancers-breathe.md | 5 +++++ packages/tabs/src/LionTabs.js | 1 + 2 files changed, 6 insertions(+) create mode 100644 .changeset/rotten-dancers-breathe.md diff --git a/.changeset/rotten-dancers-breathe.md b/.changeset/rotten-dancers-breathe.md new file mode 100644 index 000000000..750feb642 --- /dev/null +++ b/.changeset/rotten-dancers-breathe.md @@ -0,0 +1,5 @@ +--- +'@lion/tabs': patch +--- + +The store of invoker and content slottables was not properly cleared before repopulating, on slotchange event. This would cause duplicate entries. diff --git a/packages/tabs/src/LionTabs.js b/packages/tabs/src/LionTabs.js index a55fc1c69..091a2a090 100644 --- a/packages/tabs/src/LionTabs.js +++ b/packages/tabs/src/LionTabs.js @@ -229,6 +229,7 @@ export class LionTabs extends LitElement { this.__store.forEach(entry => { cleanButton(entry); }); + this.__store = []; } /**