chore(input-stepper): remove name attr and improvements
This commit is contained in:
parent
51670bd881
commit
51d2f4d28a
2 changed files with 27 additions and 8 deletions
5
.changeset/silent-steaks-marry.md
Normal file
5
.changeset/silent-steaks-marry.md
Normal file
|
|
@ -0,0 +1,5 @@
|
||||||
|
---
|
||||||
|
'@lion/input-stepper': patch
|
||||||
|
---
|
||||||
|
|
||||||
|
fix(input-stepper): make use of prefix and suffix slots
|
||||||
|
|
@ -103,8 +103,8 @@ export class LionInputStepper extends LionInput {
|
||||||
get slots() {
|
get slots() {
|
||||||
return {
|
return {
|
||||||
...super.slots,
|
...super.slots,
|
||||||
prefix: () => this.__getButtonNode(),
|
prefix: () => this.__getDecrementButtonNode(),
|
||||||
suffix: () => this.__getButtonNode(true),
|
suffix: () => this.__getIncrementButtonNode(),
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
@ -208,14 +208,30 @@ export class LionInputStepper extends LionInput {
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Get the button node
|
* Get the increment button node
|
||||||
* @param {Boolean} isIncrement flag to differentiate the template
|
|
||||||
* @returns {Element|null}
|
* @returns {Element|null}
|
||||||
*/
|
*/
|
||||||
__getButtonNode(isIncrement = false) {
|
__getIncrementButtonNode() {
|
||||||
const renderParent = document.createElement('div');
|
const renderParent = document.createElement('div');
|
||||||
/** @type {typeof LionInputStepper} */ (this.constructor).render(
|
/** @type {typeof LionInputStepper} */ (this.constructor).render(
|
||||||
isIncrement ? this._incrementorTemplate() : this._decrementorTemplate(),
|
this._incrementorTemplate(),
|
||||||
|
renderParent,
|
||||||
|
{
|
||||||
|
scopeName: this.localName,
|
||||||
|
eventContext: this,
|
||||||
|
},
|
||||||
|
);
|
||||||
|
return renderParent.firstElementChild;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Get the decrement button node
|
||||||
|
* @returns {Element|null}
|
||||||
|
*/
|
||||||
|
__getDecrementButtonNode() {
|
||||||
|
const renderParent = document.createElement('div');
|
||||||
|
/** @type {typeof LionInputStepper} */ (this.constructor).render(
|
||||||
|
this._decrementorTemplate(),
|
||||||
renderParent,
|
renderParent,
|
||||||
{
|
{
|
||||||
scopeName: this.localName,
|
scopeName: this.localName,
|
||||||
|
|
@ -271,7 +287,6 @@ export class LionInputStepper extends LionInput {
|
||||||
?disabled=${this.disabled || this.readOnly}
|
?disabled=${this.disabled || this.readOnly}
|
||||||
@click=${this.__decrement}
|
@click=${this.__decrement}
|
||||||
tabindex="-1"
|
tabindex="-1"
|
||||||
name="decrement"
|
|
||||||
type="button"
|
type="button"
|
||||||
aria-label="decrement"
|
aria-label="decrement"
|
||||||
>
|
>
|
||||||
|
|
@ -290,7 +305,6 @@ export class LionInputStepper extends LionInput {
|
||||||
?disabled=${this.disabled || this.readOnly}
|
?disabled=${this.disabled || this.readOnly}
|
||||||
@click=${this.__increment}
|
@click=${this.__increment}
|
||||||
tabindex="-1"
|
tabindex="-1"
|
||||||
name="increment"
|
|
||||||
type="button"
|
type="button"
|
||||||
aria-label="increment"
|
aria-label="increment"
|
||||||
>
|
>
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue