From 3fefc359b8704c17c292a4dedec4d691b4ebc2a4 Mon Sep 17 00:00:00 2001 From: Joren Broekema Date: Thu, 7 Jan 2021 10:02:30 +0100 Subject: [PATCH] fix(button): add user-select rule with prefixes --- .changeset/blue-frogs-enjoy.md | 5 +++++ .changeset/forty-ants-relate.md | 5 +++++ packages/button/src/LionButton.js | 3 +++ packages/select-rich/src/LionSelectInvoker.js | 1 + 4 files changed, 14 insertions(+) create mode 100644 .changeset/blue-frogs-enjoy.md create mode 100644 .changeset/forty-ants-relate.md diff --git a/.changeset/blue-frogs-enjoy.md b/.changeset/blue-frogs-enjoy.md new file mode 100644 index 000000000..7b0680571 --- /dev/null +++ b/.changeset/blue-frogs-enjoy.md @@ -0,0 +1,5 @@ +--- +'@lion/button': patch +--- + +Fix button user-select for Edge/Safari by adding prefixes for the CSS rule. diff --git a/.changeset/forty-ants-relate.md b/.changeset/forty-ants-relate.md new file mode 100644 index 000000000..2017947eb --- /dev/null +++ b/.changeset/forty-ants-relate.md @@ -0,0 +1,5 @@ +--- +'@lion/select-rich': patch +--- + +Set pointer-events to none to fix Safari bug where click event is blocked by text content wrapper. diff --git a/packages/button/src/LionButton.js b/packages/button/src/LionButton.js index 326313353..0961abdec 100644 --- a/packages/button/src/LionButton.js +++ b/packages/button/src/LionButton.js @@ -62,6 +62,9 @@ export class LionButton extends DisabledWithTabIndexMixin(SlotMixin(LitElement)) outline: none; /* focus style handled below */ cursor: default; /* /* we should always see the default arrow, never a caret */ user-select: none; + -webkit-user-select: none; + -moz-user-select: none; + -ms-user-select: none; } :host::before { diff --git a/packages/select-rich/src/LionSelectInvoker.js b/packages/select-rich/src/LionSelectInvoker.js index aa35bfb26..f6a257def 100644 --- a/packages/select-rich/src/LionSelectInvoker.js +++ b/packages/select-rich/src/LionSelectInvoker.js @@ -22,6 +22,7 @@ export class LionSelectInvoker extends LionButton { #content-wrapper { position: relative; + pointer-events: none; } `, ];