From 3c9acaa77e144c9f05a284a8b3eaab99712d30ae Mon Sep 17 00:00:00 2001 From: joquitch Date: Mon, 7 Feb 2022 09:01:29 +0100 Subject: [PATCH] fix(collapsible): moved binding to constructor --- .changeset/tender-islands-wait.md | 5 +++++ packages/collapsible/test/lion-collapsible.test.js | 8 ++++++++ 2 files changed, 13 insertions(+) create mode 100644 .changeset/tender-islands-wait.md diff --git a/.changeset/tender-islands-wait.md b/.changeset/tender-islands-wait.md new file mode 100644 index 000000000..06047bade --- /dev/null +++ b/.changeset/tender-islands-wait.md @@ -0,0 +1,5 @@ +--- +'@lion/collapsible': patch +--- + +Moved binding to constructor to be be able to remove the event listener in disconnectedCallback diff --git a/packages/collapsible/test/lion-collapsible.test.js b/packages/collapsible/test/lion-collapsible.test.js index 28b5b1e0d..edcb453fe 100644 --- a/packages/collapsible/test/lion-collapsible.test.js +++ b/packages/collapsible/test/lion-collapsible.test.js @@ -100,6 +100,14 @@ describe('', () => { await collapsible.updateComplete; expect(isCollapsibleOpen).to.equal(false); }); + + it('opens a invoker on click even if moved once', async () => { + const collapsible = await fixture(defaultCollapsible); + collapsible.remove(); + const invoker = collapsible.querySelector('[slot=invoker]'); + invoker?.dispatchEvent(new Event('click')); + expect(collapsible.opened).to.equal(true); + }); }); describe('Accessibility', () => {