ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: move icon intro to icon package so it can be extended

Browse source
This commit is contained in:
Joren Broekema 2020-06-08 11:23:46 +02:00
parent e1af39320f
commit 3ae448f826
12 changed files with 17 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/form-core/src/FocusMixin.js
View file

@ -61,7 +61,6 @@ export const FocusMixin = dedupeMixin(
}
__registerEventsForFocusMixin() {
// focus
this.__redispatchFocus = ev => {
ev.stopPropagation();
this.dispatchEvent(new Event('focus'));

2
packages/form-integrations/test/form-integrations.test.js
View file

@ -1,7 +1,7 @@
import { expect, fixture, html } from '@open-wc/testing';
import './helpers/umbrella-form.js';
// Test umbrella form
// Test umbrella form.
describe('Form Integrations', () => {
it('".serializedValue" returns all non disabled fields based on form structure', async () => {
const el = await fixture(html`<umbrella-form></umbrella-form>`);

6
docs/intros/intros-icon.md → packages/icon/docs/intros-icon.md
View file

@ -6,9 +6,9 @@ Icons are SVGs so they can be easily scaled and styled with CSS.
## Packages
| Package | Version | Description |
| --------------------------------------------- | ------------------------------------------------------------------------------------------------ | ----------- |
| [icon](?path=/docs/icons-icon--default-story) | [![icon](https://img.shields.io/npm/v/@lion/icon.svg)](https://www.npmjs.com/package/@lion/icon) | Icon |
| Package | Version | Description |
| ----------------------------------------- | ------------------------------------------------------------------------------------------------ | ----------- |
| [icon](?path=/docs/icons-icon--main#icon) | [![icon](https://img.shields.io/npm/v/@lion/icon.svg)](https://www.npmjs.com/package/@lion/icon) | Icon |
```js script
export default {

2
packages/icon/src/LionIcon.js
View file

@ -16,7 +16,7 @@ function validateSvg(svg) {
}
/**
* Custom element for rendering SVG icons
* Custom element for rendering SVG icons.
*/
export class LionIcon extends LitElement {
static get properties() {

2
packages/input-amount/src/formatters.js
View file

@ -1,7 +1,7 @@
import { formatNumber, getFractionDigits, normalizeCurrencyLabel } from '@lion/localize';
/**
* Formats a number considering the default fraction digits provided by Intl
* Formats a number considering the default fraction digits provided by Intl.
*
* @param {float} modelValue Number to format
* @param {object} givenOptions Options for Intl

4
packages/input-date/src/LionInputDate.js
View file

@ -1,6 +1,6 @@
import { IsDate } from '@lion/form-core';
import { LionInput } from '@lion/input';
import { formatDate, LocalizeMixin, parseDate } from '@lion/localize';
import { IsDate } from '@lion/form-core';
function isValidDate(date) {
// to make sure it is a valid date we use isNaN and not Number.isNaN
@ -48,7 +48,7 @@ export class LionInputDate extends LocalizeMixin(LionInput) {
return '';
}
// modelValue is localized, so we take the timezone offset in milliseconds and subtract it
// before converting it to ISO string
// before converting it to ISO string.
const offset = modelValue.getTimezoneOffset() * 60000;
return new Date(modelValue - offset).toISOString().slice(0, 10);
}

2
packages/input-datepicker/src/LionInputDatepicker.js
View file

@ -22,7 +22,7 @@ export class LionInputDatepicker extends ScopedElementsMixin(OverlayMixin(LionIn
/**
* The heading to be added on top of the calendar overlay.
* Naming chosen from an Application Developer perspective.
* For a Subclasser 'calendarOverlayHeading' would be more appropriate
* For a Subclasser 'calendarOverlayHeading' would be more appropriate.
*/
calendarHeading: {
type: String,

6
packages/input-email/src/LionInputEmail.js
View file

@ -1,6 +1,6 @@
import { LocalizeMixin } from '@lion/localize';
import { LionInput } from '@lion/input';
import { IsEmail } from '@lion/form-core';
import { LionInput } from '@lion/input';
import { LocalizeMixin } from '@lion/localize';
/**
* LionInputEmail: extension of lion-input
@ -12,7 +12,7 @@ export class LionInputEmail extends LocalizeMixin(LionInput) {
constructor() {
super();
// local-part@domain where the local part may be up to 64 characters long
// and the domain may have a maximum of 255 characters
// and the domain may have a maximum of 255 characters.
// @see https://www.wikiwand.com/en/Email_address
// however, the longest active email is even bigger
// @see https://laughingsquid.com/the-worlds-longest-active-email-address/

2
packages/input-iban/src/formatters.js
View file

@ -7,7 +7,7 @@ import { friendlyFormatIBAN } from 'ibantools';
* @return {string} formatted value
*/
export function formatIBAN(modelValue) {
// defensive code because of ibantools
// defensive code because of ibantools.
if (!modelValue) {
return '';
}

6
packages/input-range/src/LionInputRange.js
View file

@ -1,10 +1,10 @@
/* eslint-disable import/no-extraneous-dependencies */
import { LocalizeMixin, formatNumber } from '@lion/localize';
import { css, html, unsafeCSS } from '@lion/core';
import { LionInput } from '@lion/input';
import { html, css, unsafeCSS } from '@lion/core';
import { formatNumber, LocalizeMixin } from '@lion/localize';
/**
* LionInputRange: extension of lion-input
* LionInputRange: extension of lion-input.
*
* @customElement `lion-input-range`
* @extends LionInput

2
packages/input/src/LionInput.js
View file

@ -1,7 +1,7 @@
import { LionField } from '@lion/form-core';
/**
* LionInput: extension of lion-field with native input element in place and user friendly API
* LionInput: extension of lion-field with native input element in place and user friendly API.
*
* @customElement lion-input
* @extends {LionField}

1
packages/radio-group/src/LionRadio.js
View file

@ -18,7 +18,6 @@ import { LionInput } from '@lion/input';
* Example:
* <lion-radio checked>
*
*
* @customElement lion-radio
* @extends {LionInput}
*/