From 30122f0e31ef44e29c7d76b48321c534eb862859 Mon Sep 17 00:00:00 2001
From: Thijs Louisse <Thijs.Louisse@ing.com>
Date: Mon, 22 Nov 2021 18:26:38 +0100
Subject: [PATCH] fix(providence): improve perf by memoization

---
 .../src/cli/prompt-analyzer-menu.js           |  6 ++---
 .../src/program/utils/resolve-import-path.js  | 23 +++++++++++--------
 2 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/packages-node/providence-analytics/src/cli/prompt-analyzer-menu.js b/packages-node/providence-analytics/src/cli/prompt-analyzer-menu.js
index 58d81a462..8a9d18d1f 100644
--- a/packages-node/providence-analytics/src/cli/prompt-analyzer-menu.js
+++ b/packages-node/providence-analytics/src/cli/prompt-analyzer-menu.js
@@ -8,10 +8,10 @@ const { LogService } = require('../program/services/LogService.js');
 const JsdocCommentParser = require('../program/utils/jsdoc-comment-parser.js');
 
 /**
- * @desc extracts name, defaultValue, optional, type, desc from JsdocCommentParser.parse method
+ * Extracts name, defaultValue, optional, type, desc from JsdocCommentParser.parse method
  * result
- * @param {array} jsdoc
- * @returns {object}
+ * @param {string[]} jsdoc
+ * @returns {{ name:string, defaultValue:string, optional:boolean, type:string, desc:string }}
  */
 function getPropsFromParsedJsDoc(jsdoc) {
   const jsdocProps = jsdoc.filter(p => p.tagName === '@property');
diff --git a/packages-node/providence-analytics/src/program/utils/resolve-import-path.js b/packages-node/providence-analytics/src/program/utils/resolve-import-path.js
index 05ae48f00..8cf3eb49f 100644
--- a/packages-node/providence-analytics/src/program/utils/resolve-import-path.js
+++ b/packages-node/providence-analytics/src/program/utils/resolve-import-path.js
@@ -12,6 +12,7 @@
 const pathLib = require('path');
 const { nodeResolve } = require('@rollup/plugin-node-resolve');
 const { LogService } = require('../services/LogService.js');
+const { memoizeAsync } = require('./memoize.js');
 
 const fakePluginContext = {
   meta: {
@@ -27,15 +28,6 @@ const fakePluginContext = {
   },
 };
 
-/**
- * Based on importee (in a statement "import {x} from '@lion/core'", "@lion/core" is an
- * importee), which can be a bare module specifier, a filename without extension, or a folder
- * name without an extension.
- * @param {SpecifierSource} importee source like '@lion/core' or '../helpers/index.js'
- * @param {PathFromSystemRoot} importer importing file, like '/my/project/importing-file.js'
- * @param {{customResolveOptions?: {preserveSymlinks:boolean}}} [opts] nodeResolve options
- * @returns {Promise<PathFromSystemRoot|null>} the resolved file system path, like '/my/project/node_modules/@lion/core/index.js'
- */
 async function resolveImportPath(importee, importer, opts = {}) {
   const rollupResolve = nodeResolve({
     rootDir: pathLib.dirname(importer),
@@ -62,4 +54,15 @@ async function resolveImportPath(importee, importer, opts = {}) {
   return result.id;
 }
 
-module.exports = { resolveImportPath };
+/**
+ * Based on importee (in a statement "import {x} from '@lion/core'", "@lion/core" is an
+ * importee), which can be a bare module specifier, a filename without extension, or a folder
+ * name without an extension.
+ * @param {SpecifierSource} importee source like '@lion/core' or '../helpers/index.js'
+ * @param {PathFromSystemRoot} importer importing file, like '/my/project/importing-file.js'
+ * @param {{customResolveOptions?: {preserveSymlinks:boolean}}} [opts] nodeResolve options
+ * @returns {Promise<PathFromSystemRoot|null>} the resolved file system path, like '/my/project/node_modules/@lion/core/index.js'
+ */
+const resolveImportPathMemoized = memoizeAsync(resolveImportPath);
+
+module.exports = { resolveImportPath: resolveImportPathMemoized };