ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(input-tel-dropdown): use ScopedElementsMixin in to run test-suite with select-rich (#2209)

Browse source
This commit is contained in:
gerjanvangeest 2024-03-05 16:13:20 +01:00 committed by Thijs Louisse
parent e211f3cd5b
commit 2fab9e5559
2 changed files with 19 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/seven-beans-give.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/ui': patch
---
[input-tel-dropdown] use ScopedElementsMixin in to run test-suite with select-rich

21
packages/ui/components/input-tel-dropdown/test/LionInputTelDropdown.test.js
View file

@ -3,11 +3,10 @@ import { repeat } from 'lit/directives/repeat.js';
import { ref } from 'lit/directives/ref.js'; import { ref } from 'lit/directives/ref.js';
import { aTimeout, expect, fixture, html } from '@open-wc/testing'; import { aTimeout, expect, fixture, html } from '@open-wc/testing';
import { LionInputTelDropdown } from '@lion/ui/input-tel-dropdown.js'; import { LionInputTelDropdown } from '@lion/ui/input-tel-dropdown.js';
import { LionOption } from '@lion/ui/listbox.js';
import { LionSelectRich } from '@lion/ui/select-rich.js';
import { runInputTelDropdownSuite } from '@lion/ui/input-tel-dropdown-test-suites.js'; import { runInputTelDropdownSuite } from '@lion/ui/input-tel-dropdown-test-suites.js';
import { mimicUserChangingDropdown } from '@lion/ui/input-tel-dropdown-test-helpers.js'; import { ScopedElementsMixin } from '../../core/src/ScopedElementsMixin.js';
import '@lion/ui/define/lion-option.js';
import '@lion/ui/define/lion-select-rich.js';
/** /**
* @typedef {import('lit').TemplateResult} TemplateResult * @typedef {import('lit').TemplateResult} TemplateResult
@ -16,7 +15,16 @@ import '@lion/ui/define/lion-select-rich.js';
* @typedef {import('../types/index.js').RegionMeta} RegionMeta * @typedef {import('../types/index.js').RegionMeta} RegionMeta
*/ */
class WithFormControlInputTelDropdown extends LionInputTelDropdown { class WithFormControlInputTelDropdown extends ScopedElementsMixin(LionInputTelDropdown) {
/**
* @configure ScopedElementsMixin
*/
static scopedElements = {
...super.scopedElements,
'lion-select-rich': LionSelectRich,
'lion-option': LionOption,
};
static templates = { static templates = {
...(super.templates || {}), ...(super.templates || {}),
/** /**
@ -49,8 +57,7 @@ class WithFormControlInputTelDropdown extends LionInputTelDropdown {
runInputTelSuite({ klass: LionInputTelDropdown }); runInputTelSuite({ klass: LionInputTelDropdown });
runInputTelDropdownSuite(); runInputTelDropdownSuite();
// TODO: To be fixed in 4095205 describe('WithFormControlInputTelDropdown', () => {
describe.skip('WithFormControlInputTelDropdown', () => {
// @ts-expect-error // @ts-expect-error
// Runs it for LionSelectRich, which uses .modelValue/@model-value-changed instead of .value/@change // Runs it for LionSelectRich, which uses .modelValue/@model-value-changed instead of .value/@change
runInputTelDropdownSuite({ klass: WithFormControlInputTelDropdown }); runInputTelDropdownSuite({ klass: WithFormControlInputTelDropdown });