diff --git a/.changeset/six-vans-rhyme.md b/.changeset/six-vans-rhyme.md new file mode 100644 index 000000000..2ed765862 --- /dev/null +++ b/.changeset/six-vans-rhyme.md @@ -0,0 +1,10 @@ +--- +'@lion/button': minor +'@lion/calendar': minor +'@lion/core': minor +'@lion/listbox': minor +'@lion/overlays': minor +'@lion/select-rich': minor +--- + +Remove differentKeyEventNamesShimIE, since IE11 isn't supported any more diff --git a/packages/button/src/LionButton.js b/packages/button/src/LionButton.js index f0cc97b89..571749b7f 100644 --- a/packages/button/src/LionButton.js +++ b/packages/button/src/LionButton.js @@ -1,5 +1,4 @@ import { browserDetection, css, DisabledWithTabIndexMixin, html, LitElement } from '@lion/core'; -import '@lion/core/differentKeyEventNamesShimIE'; const isKeyboardClickEvent = (/** @type {KeyboardEvent} */ e) => e.key === ' ' || e.key === 'Enter'; const isSpaceKeyboardClickEvent = (/** @type {KeyboardEvent} */ e) => e.key === ' '; diff --git a/packages/button/test-suites/LionButton.suite.js b/packages/button/test-suites/LionButton.suite.js index 15ff25edc..2b7d19ded 100644 --- a/packages/button/test-suites/LionButton.suite.js +++ b/packages/button/test-suites/LionButton.suite.js @@ -1,7 +1,6 @@ /* eslint-disable lit-a11y/click-events-have-key-events */ import { LionButton } from '@lion/button'; import { browserDetection } from '@lion/core'; -import '@lion/core/differentKeyEventNamesShimIE'; import { aTimeout, defineCE, diff --git a/packages/button/test-suites/LionButtonReset.suite.js b/packages/button/test-suites/LionButtonReset.suite.js index a9a0a0ba0..ba46989ce 100644 --- a/packages/button/test-suites/LionButtonReset.suite.js +++ b/packages/button/test-suites/LionButtonReset.suite.js @@ -1,6 +1,5 @@ /* eslint-disable lit-a11y/click-events-have-key-events */ import { LionButtonReset } from '@lion/button'; -import '@lion/core/differentKeyEventNamesShimIE'; import { aTimeout, defineCE, expect, fixture, html, unsafeStatic } from '@open-wc/testing'; import sinon from 'sinon'; diff --git a/packages/button/test-suites/LionButtonSubmit.suite.js b/packages/button/test-suites/LionButtonSubmit.suite.js index f294c911b..a1d9ce15c 100644 --- a/packages/button/test-suites/LionButtonSubmit.suite.js +++ b/packages/button/test-suites/LionButtonSubmit.suite.js @@ -1,6 +1,5 @@ /* eslint-disable lit-a11y/click-events-have-key-events */ import { LionButtonSubmit } from '@lion/button'; -import '@lion/core/differentKeyEventNamesShimIE'; import { aTimeout, defineCE, expect, fixture, html, unsafeStatic } from '@open-wc/testing'; import { sendKeys } from '@web/test-runner-commands'; import sinon from 'sinon'; diff --git a/packages/calendar/src/LionCalendar.js b/packages/calendar/src/LionCalendar.js index 7e4e8037c..48b99b4f7 100644 --- a/packages/calendar/src/LionCalendar.js +++ b/packages/calendar/src/LionCalendar.js @@ -8,7 +8,6 @@ import { normalizeDateTime, } from '@lion/localize'; -import '@lion/core/differentKeyEventNamesShimIE'; import { calendarStyle } from './calendarStyle.js'; import { createDay } from './utils/createDay.js'; import { createMultipleMonth } from './utils/createMultipleMonth.js'; diff --git a/packages/core/differentKeyEventNamesShimIE.js b/packages/core/differentKeyEventNamesShimIE.js deleted file mode 100644 index 6989ddbf2..000000000 --- a/packages/core/differentKeyEventNamesShimIE.js +++ /dev/null @@ -1 +0,0 @@ -import './src/differentKeyEventNamesShimIE.js'; diff --git a/packages/core/package.json b/packages/core/package.json index 2a41fd77e..e91fccdf6 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -32,8 +32,7 @@ "test": "cd ../../ && npm run test:browser -- --group core" }, "sideEffects": [ - "./closestPolyfill.js", - "./differentKeyEventNamesShimIE.js" + "./closestPolyfill.js" ], "dependencies": { "@open-wc/dedupe-mixin": "^1.3.0", @@ -51,7 +50,6 @@ ".": "./index.js", "./test-helpers": "./test-helpers/index.js", "./closestPolyfill": "./src/closestPolyfill.js", - "./differentKeyEventNamesShimIE": "./src/differentKeyEventNamesShimIE.js", "./docs/*": "./docs/*" } } diff --git a/packages/core/src/differentKeyEventNamesShimIE.js b/packages/core/src/differentKeyEventNamesShimIE.js deleted file mode 100644 index c62b5e8c5..000000000 --- a/packages/core/src/differentKeyEventNamesShimIE.js +++ /dev/null @@ -1,40 +0,0 @@ -if (typeof window.KeyboardEvent !== 'function') { - // e.g. is IE and needs "polyfill" - const event = KeyboardEvent.prototype; - const descriptor = Object.getOwnPropertyDescriptor(event, 'key'); - if (descriptor) { - /** @type {Object.} */ - const keys = { - Win: 'Meta', - Scroll: 'ScrollLock', - Spacebar: ' ', - - Down: 'ArrowDown', - Left: 'ArrowLeft', - Right: 'ArrowRight', - Up: 'ArrowUp', - - Del: 'Delete', - Apps: 'ContextMenu', - Esc: 'Escape', - - Multiply: '*', - Add: '+', - Subtract: '-', - Decimal: '.', - Divide: '/', - }; - Object.defineProperty(event, 'key', { - // eslint-disable-next-line object-shorthand, func-names - get: function () { - if (descriptor.get) { - const key = descriptor.get.call(this); - - // eslint-disable-next-line no-prototype-builtins - return keys.hasOwnProperty(key) ? keys[key] : key; - } - return undefined; - }, - }); - } -} diff --git a/packages/listbox/src/ListboxMixin.js b/packages/listbox/src/ListboxMixin.js index 1e12d051d..68441b932 100644 --- a/packages/listbox/src/ListboxMixin.js +++ b/packages/listbox/src/ListboxMixin.js @@ -1,6 +1,5 @@ import { css, dedupeMixin, html, ScopedElementsMixin, SlotMixin } from '@lion/core'; import '@lion/core/closestPolyfill'; -import '@lion/core/differentKeyEventNamesShimIE'; import { ChoiceGroupMixin, FormControlMixin, FormRegistrarMixin } from '@lion/form-core'; import { LionOptions } from './LionOptions.js'; diff --git a/packages/listbox/test-suites/ListboxMixin.suite.js b/packages/listbox/test-suites/ListboxMixin.suite.js index 7b484e3f5..22ab53ab1 100644 --- a/packages/listbox/test-suites/ListboxMixin.suite.js +++ b/packages/listbox/test-suites/ListboxMixin.suite.js @@ -1,5 +1,4 @@ import { LitElement, repeat } from '@lion/core'; -import '@lion/core/differentKeyEventNamesShimIE'; import { Required } from '@lion/form-core'; import { LionOptions } from '@lion/listbox'; import '@lion/listbox/define'; diff --git a/packages/overlays/src/OverlayController.js b/packages/overlays/src/OverlayController.js index 4117dccf8..e8b83902f 100644 --- a/packages/overlays/src/OverlayController.js +++ b/packages/overlays/src/OverlayController.js @@ -1,4 +1,3 @@ -import '@lion/core/differentKeyEventNamesShimIE'; import { EventTargetShim } from '@lion/core'; // eslint-disable-next-line import/no-cycle import { overlays } from './overlays.js'; diff --git a/packages/overlays/test/OverlayController.test.js b/packages/overlays/test/OverlayController.test.js index 51304c27a..68857ea40 100644 --- a/packages/overlays/test/OverlayController.test.js +++ b/packages/overlays/test/OverlayController.test.js @@ -1,5 +1,4 @@ /* eslint-disable no-new */ -import '@lion/core/differentKeyEventNamesShimIE'; import { aTimeout, defineCE, expect, fixture, html, unsafeStatic } from '@open-wc/testing'; import { fixtureSync } from '@open-wc/testing-helpers'; import sinon from 'sinon'; diff --git a/packages/select-rich/src/LionSelectRich.js b/packages/select-rich/src/LionSelectRich.js index a9593a481..94a9066f3 100644 --- a/packages/select-rich/src/LionSelectRich.js +++ b/packages/select-rich/src/LionSelectRich.js @@ -1,8 +1,6 @@ import { LionListbox } from '@lion/listbox'; import { html, ScopedElementsMixin, SlotMixin, browserDetection } from '@lion/core'; import { OverlayMixin, withDropdownConfig } from '@lion/overlays'; - -import '@lion/core/differentKeyEventNamesShimIE'; import { LionSelectInvoker } from './LionSelectInvoker.js'; /** diff --git a/packages/select-rich/test/lion-select-rich-interaction.test.js b/packages/select-rich/test/lion-select-rich-interaction.test.js index 4bc366560..eeb1a9d06 100644 --- a/packages/select-rich/test/lion-select-rich-interaction.test.js +++ b/packages/select-rich/test/lion-select-rich-interaction.test.js @@ -2,7 +2,6 @@ import { Required } from '@lion/form-core'; import { expect, triggerBlurFor, triggerFocusFor, fixture } from '@open-wc/testing'; import { html } from 'lit/static-html.js'; import { browserDetection } from '@lion/core'; -import '@lion/core/differentKeyEventNamesShimIE'; import '@lion/listbox/define'; import '@lion/select-rich/define'; diff --git a/packages/select-rich/test/lion-select-rich.test.js b/packages/select-rich/test/lion-select-rich.test.js index f68f47999..afbf6146f 100644 --- a/packages/select-rich/test/lion-select-rich.test.js +++ b/packages/select-rich/test/lion-select-rich.test.js @@ -1,5 +1,4 @@ import { LitElement } from '@lion/core'; -import '@lion/core/differentKeyEventNamesShimIE'; import { renderLitAsNode } from '@lion/helpers'; import { LionOption } from '@lion/listbox'; import '@lion/listbox/define';