From 25e7b6d17b7eb0961c23c217eb6b47cc2fae28a9 Mon Sep 17 00:00:00 2001 From: Joren Broekema Date: Tue, 23 Jul 2019 10:21:52 +0200 Subject: [PATCH] chore: cleanup references --- packages/field/src/formRegistrarManager.js | 1 - packages/input-email/stories/index.stories.js | 12 ++++++------ packages/localize/src/LocalizeManager.js | 1 - packages/overlays/src/LocalOverlayController.js | 1 - packages/popup/README.md | 2 +- packages/tooltip/README.md | 2 +- 6 files changed, 8 insertions(+), 11 deletions(-) diff --git a/packages/field/src/formRegistrarManager.js b/packages/field/src/formRegistrarManager.js index 71254faa4..7d9e5c026 100644 --- a/packages/field/src/formRegistrarManager.js +++ b/packages/field/src/formRegistrarManager.js @@ -24,7 +24,6 @@ class FormRegistrarManager { } // TODO: this method has to be removed when EventTarget polyfill is available on IE11 - // issue: https://gitlab.ing.net/TheGuideComponents/lion-element/issues/12 _fakeExtendsEventTarget() { const delegate = document.createDocumentFragment(); ['addEventListener', 'dispatchEvent', 'removeEventListener'].forEach(funcName => { diff --git a/packages/input-email/stories/index.stories.js b/packages/input-email/stories/index.stories.js index 914b29195..7afe548d7 100644 --- a/packages/input-email/stories/index.stories.js +++ b/packages/input-email/stories/index.stories.js @@ -18,18 +18,18 @@ storiesOf('Forms|Input Email', module) `, ) .add('Use own validator', () => { - const ingOnly = modelValue => ({ ingOnly: modelValue.indexOf('ing.com') !== -1 }); + const gmailOnly = modelValue => ({ gmailOnly: modelValue.indexOf('gmail.com') !== -1 }); localize.locale = 'en'; try { - localize.addData('en', 'lion-validate+ingOnly', { + localize.addData('en', 'lion-validate+gmailOnly', { error: { - ingOnly: 'You can only use ing.com email addresses.', + gmailOnly: 'You can only use gmail.com email addresses.', }, }); - localize.addData('nl', 'lion-validate+ingOnly', { + localize.addData('nl', 'lion-validate+gmailOnly', { error: { - ingOnly: 'Je mag hier alleen ing.com e-mailadressen gebruiken.', + gmailOnly: 'Je mag hier alleen gmail.com e-mailadressen gebruiken.', }, }); } catch (error) { @@ -39,7 +39,7 @@ storiesOf('Forms|Input Email', module) return html` `; }); diff --git a/packages/localize/src/LocalizeManager.js b/packages/localize/src/LocalizeManager.js index 4dc730f52..b6ac25a34 100644 --- a/packages/localize/src/LocalizeManager.js +++ b/packages/localize/src/LocalizeManager.js @@ -214,7 +214,6 @@ export class LocalizeManager extends LionSingleton { } // TODO: this method has to be removed when EventTarget polyfill is available on IE11 - // issue: https://gitlab.ing.net/TheGuideComponents/lion-element/issues/12 _fakeExtendsEventTarget() { const delegate = document.createDocumentFragment(); ['addEventListener', 'dispatchEvent', 'removeEventListener'].forEach(funcName => { diff --git a/packages/overlays/src/LocalOverlayController.js b/packages/overlays/src/LocalOverlayController.js index 98383d77f..eb43ae6be 100644 --- a/packages/overlays/src/LocalOverlayController.js +++ b/packages/overlays/src/LocalOverlayController.js @@ -313,7 +313,6 @@ export class LocalOverlayController { } // TODO: this method has to be removed when EventTarget polyfill is available on IE11 - // issue: https://gitlab.ing.net/TheGuideComponents/lion-element/issues/12 __fakeExtendsEventTarget() { const delegate = document.createDocumentFragment(); ['addEventListener', 'dispatchEvent', 'removeEventListener'].forEach(funcName => { diff --git a/packages/popup/README.md b/packages/popup/README.md index ea6de6ae1..5c36b794a 100644 --- a/packages/popup/README.md +++ b/packages/popup/README.md @@ -27,7 +27,7 @@ import '@lion/popup/lion-popup.js'; ```html
This is a popup
- + Popup on link diff --git a/packages/tooltip/README.md b/packages/tooltip/README.md index 01d58f901..aae75763f 100644 --- a/packages/tooltip/README.md +++ b/packages/tooltip/README.md @@ -29,7 +29,7 @@ import '@lion/tooltip/lion-tooltip.js'; ```html
This is a popup