Merge pull request #761 from ing-bank/chore/tab-storybook

chore(tabs): improve readme for storybook
This commit is contained in:
Joren Broekema 2020-06-10 11:06:19 +02:00 committed by GitHub
commit 13bc825d5c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 18 additions and 19 deletions

View file

@ -15,7 +15,7 @@ export default {
}; };
``` ```
```js story ```js preview-story
export const main = () => html` <lion-button>Default</lion-button> `; export const main = () => html` <lion-button>Default</lion-button> `;
``` ```

View file

@ -207,7 +207,7 @@ export class LionButton extends DisabledWithTabIndexMixin(SlotMixin(LitElement))
} }
__setupDelegationInConstructor() { __setupDelegationInConstructor() {
// do not move to connectedCallback, otherwise IE11 breaks // do not move to connectedCallback, otherwise IE11 breaks.
// more info: https://github.com/ing-bank/lion/issues/179#issuecomment-511763835 // more info: https://github.com/ing-bank/lion/issues/179#issuecomment-511763835
this.addEventListener('click', this.__clickDelegationHandler, true); this.addEventListener('click', this.__clickDelegationHandler, true);
} }

View file

@ -14,7 +14,7 @@ export default {
}; };
``` ```
```js story ```js preview-story
export const main = () => html` <lion-switch label="Label" help-text="Help text"></lion-switch> `; export const main = () => html` <lion-switch label="Label" help-text="Help text"></lion-switch> `;
``` ```

View file

@ -1,6 +1,5 @@
import { ChoiceInputMixin, LionField } from '@lion/form-core';
import { css, html, ScopedElementsMixin } from '@lion/core'; import { css, html, ScopedElementsMixin } from '@lion/core';
import { ChoiceInputMixin, LionField } from '@lion/form-core';
import { LionSwitchButton } from './LionSwitchButton.js'; import { LionSwitchButton } from './LionSwitchButton.js';
export class LionSwitch extends ScopedElementsMixin(ChoiceInputMixin(LionField)) { export class LionSwitch extends ScopedElementsMixin(ChoiceInputMixin(LionField)) {
@ -72,7 +71,7 @@ export class LionSwitch extends ScopedElementsMixin(ChoiceInputMixin(LionField))
} }
/** /**
* Override this function from ChoiceInputMixin * Override this function from ChoiceInputMixin.
*/ */
// eslint-disable-next-line class-methods-use-this // eslint-disable-next-line class-methods-use-this
_isEmpty() {} _isEmpty() {}

View file

@ -14,7 +14,7 @@ export default {
}; };
``` ```
```js story ```js preview-story
export const main = () => html` export const main = () => html`
<lion-tabs> <lion-tabs>
<button slot="tab">Info</button> <button slot="tab">Info</button>
@ -37,14 +37,14 @@ export const main = () => html`
npm i --save @lion/tabs; npm i --save @lion/tabs;
``` ```
### Usage
```js ```js
import { LiontTabs } from '@lion/tabs'; import { LionTabs } from '@lion/tabs';
// or // or
import '@lion/tabs/lion-tabs.js'; import '@lion/tabs/lion-tabs.js';
``` ```
### Usage
```html ```html
<lion-tabs> <lion-tabs>
<button slot="tab">Info</button> <button slot="tab">Info</button>
@ -106,7 +106,7 @@ Below, we demonstrate on how you could dynamically add new tab + panels.
```js preview-story ```js preview-story
export const distributeNewElement = () => { export const distributeNewElement = () => {
const tagName = 'lion-tabs-experimental'; const tagName = 'demo-tabs-add-dynamically';
if (!customElements.get(tagName)) { if (!customElements.get(tagName)) {
customElements.define( customElements.define(
tagName, tagName,
@ -119,20 +119,17 @@ export const distributeNewElement = () => {
render() { render() {
return html` return html`
<h3>Append</h3> <h3>Append</h3>
<button @click="${this.__handleAppendClick}">
Append
</button>
<lion-tabs id="appendTabs"> <lion-tabs id="appendTabs">
<button slot="tab">tab 1</button> <button slot="tab">tab 1</button>
<p slot="panel">panel 1</p> <p slot="panel">panel 1</p>
<button slot="tab">tab 2</button> <button slot="tab">tab 2</button>
<p slot="panel">panel 2</p> <p slot="panel">panel 2</p>
</lion-tabs> </lion-tabs>
<button @click="${this.__handleAppendClick}">
Append
</button>
<hr /> <hr />
<h3>Push</h3> <h3>Push</h3>
<button @click="${this.__handlePushClick}">
Push
</button>
<lion-tabs id="pushTabs"> <lion-tabs id="pushTabs">
<button slot="tab">tab 1</button> <button slot="tab">tab 1</button>
<p slot="panel">panel 1</p> <p slot="panel">panel 1</p>
@ -145,6 +142,9 @@ export const distributeNewElement = () => {
`, `,
)} )}
</lion-tabs> </lion-tabs>
<button @click="${this.__handlePushClick}">
Push
</button>
`; `;
} }
constructor() { constructor() {
@ -180,7 +180,7 @@ export const distributeNewElement = () => {
}, },
); );
} }
return html` <lion-tabs-experimental></lion-tabs-experimental> `; return html` <demo-tabs-add-dynamically></demo-tabs-add-dynamically> `;
}; };
``` ```

View file

@ -67,7 +67,7 @@ export class LionTabs extends LitElement {
static get properties() { static get properties() {
return { return {
/** /**
* index number of the selected tab * index number of the selected tab.
*/ */
selectedIndex: { selectedIndex: {
type: Number, type: Number,