diff --git a/packages/input-amount/test/formatters.test.js b/packages/input-amount/test/formatters.test.js index c7ab4adb3..dbd03a7db 100644 --- a/packages/input-amount/test/formatters.test.js +++ b/packages/input-amount/test/formatters.test.js @@ -60,7 +60,7 @@ describe('formatAmount()', () => { minimumFractionDigits: 2, maximumFractionDigits: 2, }), - ).to.equal('-12.35'); + ).to.equal('−12.35'); }); it('formats the right amount of fraction digits for a certain currency', async () => { diff --git a/packages/localize/src/number/formatNumberToParts.js b/packages/localize/src/number/formatNumberToParts.js index 1a7f6f7fe..d89cc0df8 100644 --- a/packages/localize/src/number/formatNumberToParts.js +++ b/packages/localize/src/number/formatNumberToParts.js @@ -28,7 +28,10 @@ export function formatNumberToParts(number, options) { const formattedNumber = Intl.NumberFormat(computedLocale, options).format(parsedNumber); const regexSymbol = /[A-Z.,\s0-9]/; const regexCode = /[A-Z]/; + + // U+002D, Hyphen-Minus, - const regexMinusSign = /[-]/; + const regexNum = /[0-9]/; const regexSeparator = /[.,]/; const regexSpace = /[\s]/; @@ -38,7 +41,7 @@ export function formatNumberToParts(number, options) { for (let i = 0; i < formattedNumber.length; i += 1) { // detect minusSign if (regexMinusSign.test(formattedNumber[i])) { - formattedParts.push({ type: 'minusSign', value: formattedNumber[i] }); + formattedParts.push({ type: 'minusSign', value: '−' /* U+2212, 'Minus-Sign', − */ }); } // detect numbers if (regexNum.test(formattedNumber[i])) { diff --git a/packages/localize/test/number/formatNumber.test.js b/packages/localize/test/number/formatNumber.test.js index c5eb071ee..ae77c709e 100644 --- a/packages/localize/test/number/formatNumber.test.js +++ b/packages/localize/test/number/formatNumber.test.js @@ -27,32 +27,32 @@ describe('formatNumber', () => { expect(formatNumber(123456.789, currencySymbol('USD'))).to.equal('$123,456.79'); }); - it('uses minus (and not dash) to indicate negative numbers ', () => { - expect(formatNumber(-12, { style: 'decimal', maximumFractionDigits: 0 })).to.equal('-12'); + it('uses minus U+2212 (and not dash) to indicate negative numbers ', () => { + expect(formatNumber(-12, { style: 'decimal', maximumFractionDigits: 0 })).to.equal('−12'); }); it('rounds (negative) numbers e.g. `roundMode: round`', () => { expect(formatNumber(12.4, { roundMode: 'round' })).to.equal('12'); expect(formatNumber(12.6, { roundMode: 'round' })).to.equal('13'); - expect(formatNumber(-12.4, { roundMode: 'round' })).to.equal('-12'); - expect(formatNumber(-12.6, { roundMode: 'round' })).to.equal('-13'); + expect(formatNumber(-12.4, { roundMode: 'round' })).to.equal('−12'); + expect(formatNumber(-12.6, { roundMode: 'round' })).to.equal('−13'); }); it("rounds (negative) numbers up when `roundMode: 'ceiling'`", () => { expect(formatNumber(12.4, { roundMode: 'ceiling' })).to.equal('13'); expect(formatNumber(12.6, { roundMode: 'ceiling' })).to.equal('13'); - expect(formatNumber(-12.4, { roundMode: 'ceiling' })).to.equal('-12'); - expect(formatNumber(-12.6, { roundMode: 'ceiling' })).to.equal('-12'); + expect(formatNumber(-12.4, { roundMode: 'ceiling' })).to.equal('−12'); + expect(formatNumber(-12.6, { roundMode: 'ceiling' })).to.equal('−12'); }); it('rounds (negative) numbers down when `roundMode: floor`', () => { expect(formatNumber(12.4, { roundMode: 'floor' })).to.equal('12'); expect(formatNumber(12.6, { roundMode: 'floor' })).to.equal('12'); - expect(formatNumber(-12.4, { roundMode: 'floor' })).to.equal('-13'); - expect(formatNumber(-12.6, { roundMode: 'floor' })).to.equal('-13'); + expect(formatNumber(-12.4, { roundMode: 'floor' })).to.equal('−13'); + expect(formatNumber(-12.6, { roundMode: 'floor' })).to.equal('−13'); }); it('returns empty string when NaN', () => { diff --git a/packages/localize/test/number/formatNumberToParts.test.js b/packages/localize/test/number/formatNumberToParts.test.js index f9ffd103e..96aec103e 100644 --- a/packages/localize/test/number/formatNumberToParts.test.js +++ b/packages/localize/test/number/formatNumberToParts.test.js @@ -10,7 +10,7 @@ const i = v => ({ type: 'integer', value: v }); const f = v => ({ type: 'fraction', value: v }); const g = v => ({ type: 'group', value: v }); const l = v => ({ type: 'literal', value: v }); -const m = { type: 'minusSign', value: '-' }; +const m = { type: 'minusSign', value: '−' }; const stringifyParts = parts => parts.map(part => part.value).join('');