ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tabs): allow initialization without children

Browse source
This commit is contained in:
Thijs Louisse 2022-03-21 21:43:20 +01:00 committed by Thijs Louisse
parent 0b5ed48e74
commit 03c294c9ea
3 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/hip-buses-itch.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/tabs': patch
---
tabs: allow to be initialized withhout children

2
packages/tabs/src/LionTabs.js
View file

@ -164,7 +164,7 @@ export class LionTabs extends LitElement {
firstUpdated(changedProperties) { firstUpdated(changedProperties) {
super.firstUpdated(changedProperties); super.firstUpdated(changedProperties);
this.__setupSlots(); this.__setupSlots();
if (this.tabs[0].disabled) { if (this.tabs[0]?.disabled) {
this.selectedIndex = this.tabs.findIndex(tab => !tab.disabled); this.selectedIndex = this.tabs.findIndex(tab => !tab.disabled);
} }
} }

5
packages/tabs/test/lion-tabs.test.js
View file

@ -112,6 +112,11 @@ describe('<lion-tabs>', () => {
); );
expect(selectedTab.textContent).to.equal('tab 2'); expect(selectedTab.textContent).to.equal('tab 2');
}); });
it('can initially be instantiated without children', async () => {
const el = /** @type {LionTabs} */ (await fixture(html` <lion-tabs> </lion-tabs> `));
expect(el.tabs).to.eql([]);
});
}); });
describe('Tabs ([slot=tab])', () => { describe('Tabs ([slot=tab])', () => {