Commit graph

14 commits

Author SHA1 Message Date
Forrest
83677a2235 fix(choose-fonts): guard preview rendering against partial terminal color query
The choose-fonts kitten queries the terminal for the user's foreground and
background colors at startup by sending a DCS request. The terminal responds
with separate DCS response strings — one per field — which arrive
asynchronously through on_query_response.

The background handler unconditionally called draw_screen() after storing its
value. If the terminal's DCS response for "background" arrived before the
response for "foreground", draw_screen() fired with text_style.Foreground
still at its Go zero value ("").

The font list preview (list.go) only guarded against empty Background, not
empty Foreground, so it passed the check and sent a render_family_samples
command to the Python backend with foreground="". The backend's to_color('')
raised ValueError: Invalid color name: '', crashing the kitten.

The faces pane (faces.go) launched a render_family_samples goroutine
unconditionally when its preview cache was empty, with no guard at all.

Fix
---
1. ui.go — Only trigger draw_screen() from the foreground or background
   handler when the counterpart field is already populated, so the UI
   never renders with a partial TextStyle.

2. list.go — Require both Foreground and Background to be non-empty
   before rendering the font preview, not just Background alone.

3. faces.go — Skip the render_family_samples goroutine if either color
   field is still empty. The preview cache stays empty, so the next
   redraw (triggered when the counterpart query response arrives, or
   by on_wakeup) retries with full colors.
2026-06-10 02:18:18 -07:00
Kovid Goyal
c861259e3b
Rename go module from kitty -> github.com/kovidgoyal/kitty
Makes the code more easily re-useable in other projects
2025-05-16 08:43:39 +05:30
Kovid Goyal
2638c7241f
Preserve auto setting when re-running choose-fonts on already selected family 2024-06-24 07:54:19 +05:30
Kovid Goyal
e2919a0f2d
Fix preview rendering when height of previewed font greater than cell height 2024-06-24 07:54:18 +05:30
Kovid Goyal
7fafdeef48
More work on choose_fonts 2024-06-24 07:54:17 +05:30
Kovid Goyal
0028d7f04b
More work on face fine tuning 2024-06-24 07:54:16 +05:30
Kovid Goyal
4de06fbeb2
Fix face sample rendering 2024-06-24 07:54:15 +05:30
Kovid Goyal
5d86f5c93f
Start work on face panel 2024-06-24 07:54:15 +05:30
Kovid Goyal
4a0aa012e4
... 2024-06-24 07:54:15 +05:30
Kovid Goyal
e23243ec78
Use PSname in faces preview panel 2024-06-24 07:54:15 +05:30
Kovid Goyal
f62fd424d2
Transmit metadata about rendered samples 2024-06-24 07:54:15 +05:30
Kovid Goyal
a4bff36baf
Get rendering of faces panel working 2024-06-24 07:54:15 +05:30
Kovid Goyal
409009a337
Work on faces panel 2024-06-24 07:54:15 +05:30
Kovid Goyal
802ed976a9
Start work on faces panel 2024-06-24 07:54:15 +05:30