Fix a regression in 0.17 that broke the kitty @ launch remote command and also broke the --tab-title option when creating a new tab.

Fixes #2488
This commit is contained in:
Kovid Goyal 2020-03-28 08:43:32 +05:30
parent 90985cc846
commit f04680ac47
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
3 changed files with 6 additions and 2 deletions

View file

@ -25,6 +25,9 @@ To update |kitty|, :doc:`follow the instructions <binary>`.
- Fix regression causing incorrect rendering of separators in tab bar when
defining a tab bar background color (:pull:`2480`)
- Fix a regression in 0.17 that broke the kitty @ launch remote command and
also broke the --tab-title option when creating a new tab. (:iss:`2488`)
0.17.1 [2020-03-24]
--------------------

View file

@ -176,7 +176,7 @@ def tab_for_window(boss: Boss, opts: LaunchCLIOptions, target_tab: Optional[Tab]
tm = boss.active_tab_manager
if tm:
tab: Optional[Tab] = tm.new_tab(empty_tab=True, location=opts.location)
if opts.tab_title and tab:
if opts.tab_title and tab is not None:
tab.set_title(opts.tab_title)
else:
tab = None

View file

@ -5,6 +5,7 @@
from typing import TYPE_CHECKING, Optional
from kitty.cli_stub import LaunchCLIOptions
from kitty.launch import (
launch as do_launch, options_spec as launch_options_spec,
parse_launch_args
@ -16,7 +17,7 @@
)
if TYPE_CHECKING:
from kitty.cli_stub import LaunchRCOptions as CLIOptions, LaunchCLIOptions
from kitty.cli_stub import LaunchRCOptions as CLIOptions
class Launch(RemoteCommand):