ayo/kitty
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

address review: fix comment wording and rename burst_actions variable

Browse source
This commit is contained in:
copilot-swe-agent[bot] 2026-06-02 12:46:10 +00:00 committed by GitHub
parent d80fd1c23d
commit bff5af7052
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
tools/watch/api_test.go
View file

@ -223,8 +223,9 @@ func wait_for_count(counter *atomic.Int32, target int32, timeout time.Duration)
// TestWatchForConfigChanges consolidates all watcher integration tests into a single // TestWatchForConfigChanges consolidates all watcher integration tests into a single
// function that starts the watcher once and confirms readiness via prime_watcher // function that starts the watcher once and confirms readiness via prime_watcher
// instead of a blind time.Sleep. All include-watching scenarios (basic, added, // instead of a blind time.Sleep. Include-watching scenarios (file changes, include
// removed, and added via an already-included file) run as sequential subtests. // added/removed from main config, include added to an already-included file) run as
// sequential subtests.
func TestWatchForConfigChanges(t *testing.T) { func TestWatchForConfigChanges(t *testing.T) {
tdir := resolve_path(t.TempDir()) tdir := resolve_path(t.TempDir())
subdir := filepath.Join(tdir, "sub") subdir := filepath.Join(tdir, "sub")
@ -406,17 +407,17 @@ func TestWatchForConfigChangesDebounce(t *testing.T) {
// Wait for up to one full debounce period for the first action to fire. // Wait for up to one full debounce period for the first action to fire.
count_after_burst := wait_for_count(&action_count, before_burst+1, debounce+500*time.Millisecond) count_after_burst := wait_for_count(&action_count, before_burst+1, debounce+500*time.Millisecond)
burst_actions := count_after_burst - before_burst action_calls_in_burst := count_after_burst - before_burst
// Debouncing should have collapsed the burst into at most 2 calls. // Debouncing should have collapsed the burst into at most 2 calls.
// The fswatcher debouncer uses leading-edge logic: the first event fires // The fswatcher debouncer uses leading-edge logic: the first event fires
// immediately and subsequent events within the cooldown window are dropped. // immediately and subsequent events within the cooldown window are dropped.
// A trailing event may fire at the end of the cooldown window, giving at most 2. // A trailing event may fire at the end of the cooldown window, giving at most 2.
if burst_actions == 0 { if action_calls_in_burst == 0 {
t.Fatalf("Expected at least one action call after burst of writes, got 0") t.Fatalf("Expected at least one action call after burst of writes, got 0")
} }
if burst_actions > 2 { if action_calls_in_burst > 2 {
t.Fatalf("Expected debouncing to collapse burst: want ≤2 calls, got %d", burst_actions) t.Fatalf("Expected debouncing to collapse burst: want ≤2 calls, got %d", action_calls_in_burst)
} }
// After waiting well past the debounce window, a new write should trigger exactly one more call. // After waiting well past the debounce window, a new write should trigger exactly one more call.