ayo/kitty
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Proper confirm_os_window_close check condition

Browse source
This commit is contained in:
Kovid Goyal 2020-05-21 15:12:20 +05:30
parent e38690e8d9
commit be05d9c3e9
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
kitty/boss.py
View file

@ -732,7 +732,8 @@ def close_os_window(self) -> None:
def confirm_os_window_close(self, os_window_id: int) -> None:
tm = self.os_window_map.get(os_window_id)
if tm is None or self.opts.confirm_os_window_close > tm.number_of_windows:
needs_confirmation = tm is not None and self.opts.confirm_os_window_close > 0 and tm.number_of_windows >= self.opts.confirm_os_window_close
if not needs_confirmation:
mark_os_window_for_close(os_window_id)
return
if tm is not None:
@ -768,11 +769,13 @@ def quit(self, *args: Any) -> None:
num = 0
for q in self.os_window_map.values():
num += q.number_of_windows
if self.opts.confirm_os_window_close > num or tm is None:
needs_confirmation = tm is not None and self.opts.confirm_os_window_close > 0 and num >= self.opts.confirm_os_window_close
if not needs_confirmation:
set_application_quit_request(IMPERATIVE_CLOSE_REQUESTED)
return
if current_application_quit_request() == CLOSE_BEING_CONFIRMED:
return
assert tm is not None
self._run_kitten('ask', ['--type=yesno', '--message', _(
'Are you sure you want to quit kitty, it has {} windows running?').format(num)],
window=tm.active_window,