ayo/kitty
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid exception when generating minimal borders for empty tab in tall/vertical layouts

Browse source
This commit is contained in:
Kovid Goyal 2020-08-30 20:02:02 +05:30
parent 430eaefc3e
commit ad57467c93
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
2 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
kitty/layout/tall.py
View file

@ -204,9 +204,12 @@ def layout_action(self, action_name: str, args: Sequence[str], all_windows: Wind
def minimal_borders(self, all_windows: WindowList) -> Generator[BorderLine, None, None]:
num = all_windows.num_groups
if num == 1 or not lgd.draw_minimal_borders:
if num < 2 or not lgd.draw_minimal_borders:
return
bw = next(all_windows.iter_all_layoutable_groups()).effective_border()
try:
bw = next(all_windows.iter_all_layoutable_groups()).effective_border()
except StopIteration:
bw = 0
if not bw:
return
if num <= self.num_full_size_windows + 1:

7
kitty/layout/vertical.py
View file

@ -24,7 +24,10 @@ def borders(
borders: List[BorderLine] = []
active_group = all_windows.active_group
needs_borders_map = all_windows.compute_needs_borders_map(lgd.draw_active_borders)
bw = next(all_windows.iter_all_layoutable_groups()).effective_border()
try:
bw = next(all_windows.iter_all_layoutable_groups()).effective_border()
except StopIteration:
bw = 0
if not bw:
return
@ -112,7 +115,7 @@ def do_layout(self, all_windows: WindowList) -> None:
def minimal_borders(self, all_windows: WindowList) -> Generator[BorderLine, None, None]:
window_count = all_windows.num_groups
if window_count == 1 or not lgd.draw_minimal_borders:
if window_count < 2 or not lgd.draw_minimal_borders:
return
yield from borders(self.generate_layout_data(all_windows), self.main_is_horizontal, all_windows)