ayo/kitty
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Handle on_drop being called with a POSIX errno

Browse source
This commit is contained in:
Kovid Goyal 2026-02-08 22:10:03 +05:30
parent ff70e2e3ab
commit abb1141826
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
2 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
kitty/boss.py
View file

@ -1885,9 +1885,14 @@ def update_tab_bar_data(self, os_window_id: int) -> None:
if tm is not None:
tm.update_tab_bar_data()
def on_drop(self, os_window_id: int, drop: dict[str, bytes] | Exception, from_self: bool, x: int, y: int) -> None:
if isinstance(drop, Exception):
self.show_error(_('Drop failed'), str(drop))
def on_drop(self, os_window_id: int, drop: dict[str, bytes] | int, from_self: bool, x: int, y: int) -> None:
if isinstance(drop, int):
import errno
code = errno.errorcode.get(drop, str(drop))
msg = 'Unknown error'
with suppress(ValueError):
msg = os.strerror(drop)
self.show_error(_('Drop failed'), f'[{code}] {msg}')
return
if (tm := self.os_window_map.get(os_window_id)) is None:
return

3
kitty/glfw.c
View file

@ -1669,8 +1669,7 @@ create_os_window(PyObject UNUSED *self, PyObject *args, PyObject *kw) {
glfwSetScrollCallback(glfw_window, scroll_callback);
glfwSetKeyboardCallback(glfw_window, key_callback);
if (0) glfwSetDragSourceCallback(glfw_window, drag_source_callback);
glfwSetDragSourceCallback(glfw_window, drag_source_callback);
glfwSetDropEventCallback(glfw_window, on_drop);
monotonic_t now = monotonic();
w->is_focused = true;