From 4a0b189bcef87decd07f7c764fc0ca189ae9c4cb Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 6 May 2026 03:42:19 +0000 Subject: [PATCH] Fix loop style in detect_tempdir_case_sensitivity and lowercase_copy Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/8c155dc2-c7ee-448f-9300-825f74411ddd Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com> --- kitty/dnd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kitty/dnd.c b/kitty/dnd.c index 5e2c90256..6fed8d749 100644 --- a/kitty/dnd.c +++ b/kitty/dnd.c @@ -153,7 +153,8 @@ detect_tempdir_case_sensitivity(const char *tempdir_path) { if (!basename_len) return; char upper_basename[PATH_MAX]; if (basename_len >= sizeof(upper_basename)) return; - for (size_t i = 0; i <= basename_len; i++) upper_basename[i] = (char)toupper((unsigned char)basename[i]); + for (size_t i = 0; i < basename_len; i++) upper_basename[i] = (char)toupper((unsigned char)basename[i]); + upper_basename[basename_len] = '\0'; if (strcmp(upper_basename, basename) == 0) return; // already all-uppercase, cannot distinguish char upper_path[PATH_MAX]; if (dirname_len + 1 + basename_len + 1 > sizeof(upper_path)) return; @@ -1850,7 +1851,8 @@ lowercase_copy(const char *s) { size_t len = strlen(s); char *ans = malloc(len + 1); if (!ans) return NULL; - for (size_t i = 0; i <= len; i++) ans[i] = (char)tolower((unsigned char)s[i]); + for (size_t i = 0; i < len; i++) ans[i] = (char)tolower((unsigned char)s[i]); + ans[len] = '\0'; return ans; }