From 3a8253e747f49641535af9cd655bd60fcc7adaf4 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 9 Apr 2026 15:41:12 +0000 Subject: [PATCH] Address code review: add buffer overflow safety in drop_append_request_keys Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/cdeecb3c-8589-4622-8f6b-21b724e4d5fd Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com> --- kitty/dnd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kitty/dnd.c b/kitty/dnd.c index 9fe335673..59ebba0f5 100644 --- a/kitty/dnd.c +++ b/kitty/dnd.c @@ -415,11 +415,11 @@ get_errno_name(int err) { static int drop_append_request_keys(Window *w, char *buf, size_t bufsize) { int sz = 0; - if (w->drop.current_request_x) + if (w->drop.current_request_x && sz < (int)bufsize - 1) sz += snprintf(buf + sz, bufsize - sz, ":x=%d", (int)w->drop.current_request_x); - if (w->drop.current_request_y) + if (w->drop.current_request_y && sz < (int)bufsize - 1) sz += snprintf(buf + sz, bufsize - sz, ":y=%d", (int)w->drop.current_request_y); - if (w->drop.current_request_Y) + if (w->drop.current_request_Y && sz < (int)bufsize - 1) sz += snprintf(buf + sz, bufsize - sz, ":Y=%d", (int)w->drop.current_request_Y); return sz; }