ayo/kitty
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cant flush response in a parser callback as it can cause recursive parsing

Browse source
This commit is contained in:
Kovid Goyal 2023-07-20 20:51:12 +05:30
parent f4c96715ac
commit 39f7f2d7b4
No known key found for this signature in database
GPG key ID: 06BC317B515ACE7C
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
kitty/parser.c
View file

@ -1170,7 +1170,7 @@ accumulate_osc(Screen *screen, uint32_t ch, PyObject DUMP_UNUSED *dump_callback,
default:
if (screen->parser_buf_pos >= PARSER_BUF_SZ - 1) {
if (handle_extended_osc_code(screen)) *extended_osc_code = true;
else REPORT_ERROR("OSC sequence too long, truncating.");
else REPORT_ERROR("OSC sequence too long (> %d bytes) truncating.", PARSER_BUF_SZ);
return true;
}
screen->parser_buf[screen->parser_buf_pos++] = ch;

2
kitty_tests/file_transmission.py
View file

@ -164,7 +164,7 @@ def __init__(self, pty, allow=True):
self.pty.callbacks.ftc = self
def write_ftc_to_child(self, payload: FileTransmissionCommand, appendleft: bool = False, use_pending: bool = True) -> bool:
self.pty.write_to_child('\x1b]' + payload.serialize(prefix_with_osc_code=True) + '\x1b\\', flush=True)
self.pty.write_to_child('\x1b]' + payload.serialize(prefix_with_osc_code=True) + '\x1b\\', flush=False)
class TransferPTY(PTY):