From 932ef781315b78a3d9715ef46dc452a0424edec5 Mon Sep 17 00:00:00 2001 From: Shaojun Liu <61072813+liu-shaojun@users.noreply.github.com> Date: Wed, 3 Jul 2024 16:49:54 +0800 Subject: [PATCH] Update Workflow Inputs, Runner, and PR Validation Process (#11501) * update check-artifact runner label to Shire * update github.event.inputs to inputs * update PR template --- .github/pull_request_template.md | 2 +- .github/workflows/llm-binary-build.yml | 12 ++++++------ .github/workflows/llm-nightly-test.yml | 6 +++--- .github/workflows/llm_example_tests.yml | 2 +- .github/workflows/llm_performance_tests.yml | 8 ++++---- .github/workflows/llm_unit_tests.yml | 4 ++-- .github/workflows/manually_build.yml | 2 +- .github/workflows/release-pypi.yml | 6 +++--- 8 files changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e7142060..38bfe592 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -19,7 +19,7 @@ ### 4. How to test? - [ ] N/A -- [ ] Unit test: Please manually trigger the PR Validation [here](https://github.com/intel-analytics/ipex-llm-workflow/actions/workflows/llm-PR-validation.yml) by inputting the full commit ID (SHA value) of your last commit (e.g., `a1b2c3d4e5f6g7h8i9j0`). And paste your action link here once it has been successfully finished. +- [ ] Unit test: Please manually trigger the PR Validation [here](https://github.com/intel-analytics/ipex-llm-workflow/actions/workflows/llm-PR-validation.yml) by inputting the PR number (e.g., `1234`). And paste your action link here once it has been successfully finished. - [ ] Application test - [ ] Document test - [ ] ... diff --git a/.github/workflows/llm-binary-build.yml b/.github/workflows/llm-binary-build.yml index 3ce228f0..26f061b3 100644 --- a/.github/workflows/llm-binary-build.yml +++ b/.github/workflows/llm-binary-build.yml @@ -48,7 +48,7 @@ on: jobs: check-linux-avxvnni-artifact: if: ${{contains(inputs.platform, 'Linux')}} - runs-on: ubuntu-latest + runs-on: [Shire] outputs: if-exists: ${{steps.check_artifact.outputs.exists}} steps: @@ -116,7 +116,7 @@ jobs: check-linux-avx512-artifact: if: ${{contains(inputs.platform, 'Linux')}} - runs-on: ubuntu-latest + runs-on: [Shire] outputs: if-exists: ${{steps.check_artifact.outputs.exists}} steps: @@ -218,7 +218,7 @@ jobs: check-linux-amx-artifact: if: ${{contains(inputs.platform, 'Linux')}} - runs-on: ubuntu-latest + runs-on: [Shire] outputs: if-exists: ${{steps.check_artifact.outputs.exists}} steps: @@ -278,7 +278,7 @@ jobs: check-windows-avx2-artifact: if: ${{contains(inputs.platform, 'Windows')}} - runs-on: ubuntu-latest + runs-on: [Shire] outputs: if-exists: ${{steps.check_artifact.outputs.exists}} steps: @@ -323,7 +323,7 @@ jobs: check-windows-avx-vnni-artifact: if: ${{contains(inputs.platform, 'Windows')}} - runs-on: ubuntu-latest + runs-on: [Shire] outputs: if-exists: ${{steps.check_artifact.outputs.exists}} steps: @@ -388,7 +388,7 @@ jobs: check-windows-avx-artifact: if: ${{contains(inputs.platform, 'Windows')}} - runs-on: ubuntu-latest + runs-on: [Shire] outputs: if-exists: ${{steps.check_artifact.outputs.exists}} steps: diff --git a/.github/workflows/llm-nightly-test.yml b/.github/workflows/llm-nightly-test.yml index 4ea4ce1e..ca12c705 100644 --- a/.github/workflows/llm-nightly-test.yml +++ b/.github/workflows/llm-nightly-test.yml @@ -77,7 +77,7 @@ jobs: - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # actions/checkout@v3 with: repository: 'intel-analytics/ipex-llm' - ref: ${{ github.event.inputs.checkout-ref }} + ref: ${{ inputs.checkout-ref }} - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v4 with: @@ -118,9 +118,9 @@ jobs: needs: llm-cpp-build uses: ./.github/workflows/llm_unit_tests.yml with: - checkout-ref: ${{ github.event.inputs.checkout-ref }} + checkout-ref: ${{ inputs.checkout-ref }} llm-example-test: needs: llm-cpp-build uses: ./.github/workflows/llm_example_tests.yml with: - checkout-ref: ${{ github.event.inputs.checkout-ref }} + checkout-ref: ${{ inputs.checkout-ref }} diff --git a/.github/workflows/llm_example_tests.yml b/.github/workflows/llm_example_tests.yml index e3e08bfc..b6672c42 100644 --- a/.github/workflows/llm_example_tests.yml +++ b/.github/workflows/llm_example_tests.yml @@ -53,7 +53,7 @@ jobs: - uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # actions/checkout@v2 with: repository: 'intel-analytics/ipex-llm' - ref: ${{ github.event.inputs.checkout-ref }} + ref: ${{ inputs.checkout-ref }} - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v2 with: diff --git a/.github/workflows/llm_performance_tests.yml b/.github/workflows/llm_performance_tests.yml index e9f2aea3..96aaa1cf 100644 --- a/.github/workflows/llm_performance_tests.yml +++ b/.github/workflows/llm_performance_tests.yml @@ -76,7 +76,7 @@ jobs: platform: ${{ (github.event_name == 'workflow_dispatch' && (inputs.checkout-ref != 'main')) && 'Windows,Linux' || 'Dummy' }} llm-performance-test-on-arc: - if: ${{ github.event.schedule || ( github.event_name == 'workflow_dispatch' && inputs.arc ) || github.event.inputs.artifact == 'llm-performance-test-on-arc' || github.event.inputs.artifact == 'all' }} # please comment it for PR tests + if: ${{ github.event.schedule || ( github.event_name == 'workflow_dispatch' && inputs.arc ) }} # please comment it for PR tests needs: llm-cpp-build strategy: fail-fast: false @@ -350,7 +350,7 @@ jobs: llm-performance-test-on-spr: - if: ${{ github.event.schedule || ( github.event_name == 'workflow_dispatch' && inputs.spr ) || github.event.inputs.artifact == 'llm-performance-test-on-spr' || github.event.inputs.artifact == 'all' }} # please comment it for PR tests + if: ${{ github.event.schedule || ( github.event_name == 'workflow_dispatch' && inputs.spr ) }} # please comment it for PR tests needs: llm-cpp-build strategy: fail-fast: false @@ -428,7 +428,7 @@ jobs: done llm-performance-test-on-core: - if: ${{ github.event.schedule || ( github.event_name == 'workflow_dispatch' && inputs.core ) || github.event.inputs.artifact == 'llm-performance-test-on-core' || github.event.inputs.artifact == 'all' }} # please comment it for PR tests + if: ${{ github.event.schedule || ( github.event_name == 'workflow_dispatch' && inputs.core ) }} # please comment it for PR tests needs: llm-cpp-build strategy: fail-fast: false @@ -509,7 +509,7 @@ jobs: fi llm-performance-test-on-igpu: - if: ${{ github.event.schedule || ( github.event_name == 'workflow_dispatch' && inputs.igpu ) || github.event.inputs.artifact == 'llm-performance-test-on-igpu' || github.event.inputs.artifact == 'all' }} # please comment it for PR tests + if: ${{ github.event.schedule || ( github.event_name == 'workflow_dispatch' && inputs.igpu ) }} # please comment it for PR tests needs: llm-cpp-build strategy: fail-fast: false diff --git a/.github/workflows/llm_unit_tests.yml b/.github/workflows/llm_unit_tests.yml index 68c8157a..942ab065 100644 --- a/.github/workflows/llm_unit_tests.yml +++ b/.github/workflows/llm_unit_tests.yml @@ -118,7 +118,7 @@ jobs: - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # actions/checkout@v3 with: repository: 'intel-analytics/ipex-llm' - ref: ${{ github.event.inputs.checkout-ref }} + ref: ${{ inputs.checkout-ref }} - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v4 with: @@ -277,7 +277,7 @@ jobs: uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # actions/checkout@v3 with: repository: 'intel-analytics/ipex-llm' - ref: ${{ github.event.inputs.checkout-ref }} + ref: ${{ inputs.checkout-ref }} - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v4 with: diff --git a/.github/workflows/manually_build.yml b/.github/workflows/manually_build.yml index 4bfdb567..bc84d9f0 100644 --- a/.github/workflows/manually_build.yml +++ b/.github/workflows/manually_build.yml @@ -31,7 +31,7 @@ on: workflow_call: inputs: checkout-ref: - description: 'commit id (SHA-1 hash)' + description: 'ref for checking out, including branch, tag or SHA' required: true type: string artifact: diff --git a/.github/workflows/release-pypi.yml b/.github/workflows/release-pypi.yml index 7b8efa9b..68c89557 100644 --- a/.github/workflows/release-pypi.yml +++ b/.github/workflows/release-pypi.yml @@ -39,7 +39,7 @@ jobs: - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # actions/checkout@v3 with: repository: 'intel-analytics/ipex-llm' - ref: ${{ github.event.inputs.checkout-ref }} + ref: ${{ inputs.checkout-ref }} - name: Set up Python uses: actions/setup-python@v2 @@ -58,12 +58,12 @@ jobs: - name: set release version run: | - if [[ "${{ github.event.inputs.schedule-event }}" == "true" ]]; then + if [[ "${{ inputs.schedule-event }}" == "true" ]]; then export TIMESTAMP=`date '+%Y%m%d'` export PYPI_VERSION=2.1.0 export RELEASE_VERSION=${PYPI_VERSION}b${TIMESTAMP} else - export RELEASE_VERSION=${{ github.event.inputs.release-version }} + export RELEASE_VERSION=${{ inputs.release-version }} fi echo "RELEASE_VERSION=${RELEASE_VERSION}" >> $GITHUB_ENV