From 4cbd95d91141b2694d66ede5ec991c760ea4688c Mon Sep 17 00:00:00 2001
From: Ayo Ayco <ramon.aycojr@gmail.com>
Date: Fri, 30 Jun 2023 12:57:25 +0200
Subject: [PATCH] refactor: minor clean up (#71)

* remove unnecessary leftovers

* add comment
---
 src/components/AddressBar.astro | 20 ++++++++------------
 src/components/Library.astro    |  6 +++++-
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/components/AddressBar.astro b/src/components/AddressBar.astro
index 00eae41..15afadb 100644
--- a/src/components/AddressBar.astro
+++ b/src/components/AddressBar.astro
@@ -61,7 +61,7 @@ const { url } = Astro.props;
     width: 100%;
   }
 
-  :global(form) {
+  form {
     width: 100%;
     border: 0px;
     padding: 0.5rem;
@@ -72,7 +72,7 @@ const { url } = Astro.props;
     box-shadow: 0 1px 3px 1px #eee;
     display: flex;
 
-    :global(input[type="url"]) {
+    input[type="url"] {
       flex: 3;
       background-color: white;
       border-radius: 5px;
@@ -81,17 +81,14 @@ const { url } = Astro.props;
       color: #555;
     }
 
-    :global(button#app-home),
-    :global(button#app-back),
-    :global(button#submit),
-    :global(button#gh-link) {
+    button{
       border: 0px;
       background-color: transparent;
       padding: 0px;
       cursor: pointer;
       color: black;
 
-      :global(svg) {
+      svg {
           border: 0px;
           background-color: transparent;
           width: 1.5rem;
@@ -99,19 +96,18 @@ const { url } = Astro.props;
       }
     }
 
-    :global(.left-buttons) {
+    .left-buttons {
       margin-right: 0.5rem;
     }
-    :global(.right-buttons) {
+    .right-buttons {
       margin-left: 0.5rem;
     }
 
-    :global(button:hover),
-    :global(button.primary-button) {
+    button:hover {
       color: blue !important;
     }
 
-    :global(button[disabled="true"]) {
+    button[disabled="true"] {
       color: #ccc !important;
       cursor: default !important;
     }
diff --git a/src/components/Library.astro b/src/components/Library.astro
index 78ce5c8..a7ab532 100644
--- a/src/components/Library.astro
+++ b/src/components/Library.astro
@@ -109,7 +109,7 @@ const {routerOutlet, skipSave = false} = Astro.props;
 
 <style lang="scss">
   #library {
-    :global(span#heading) {
+    span#heading {
       color: #555;
       font-size: small;
       text-transform: uppercase;
@@ -117,6 +117,10 @@ const {routerOutlet, skipSave = false} = Astro.props;
   }
   #post-list {
 
+    /**
+    `:global` is needed for elements not generated by Astro
+      - can be improved by CSS in JS, but... this is fine
+    */
     :global(li) {
       list-style: none;
       width: calc(100% + 40px);