From 343568042c16e035e1211860bbbccc3a441ff375 Mon Sep 17 00:00:00 2001 From: Ayo Date: Tue, 26 Aug 2025 00:53:34 +0200 Subject: [PATCH] refactor(sw): check for fallbackUrl --- src/sw.mjs | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/sw.mjs b/src/sw.mjs index 6e68b0b..4dd8380 100644 --- a/src/sw.mjs +++ b/src/sw.mjs @@ -78,9 +78,6 @@ const networkFirst = async ({ request, fallbackUrl }) => { try { // Try to get the resource from the network for 5 seconds const responseFromNetwork = await fetch(request.clone()) - // response may be used only once - // we need to save clone to put one copy in cache - // and serve second one putInCache(request, responseFromNetwork.clone()) console.info('using network response', responseFromNetwork.url) return responseFromNetwork @@ -93,11 +90,13 @@ const networkFirst = async ({ request, fallbackUrl }) => { return responseFromCache } - // Try the fallback - const fallbackResponse = await cache.match(fallbackUrl) - if (fallbackResponse) { - console.info('using fallback cached response...', fallbackResponse.url) - return fallbackResponse + // If fallback is provided, try to use it, otherwise return error + if (fallbackUrl) { + const fallbackResponse = await cache.match(fallbackUrl) + if (fallbackResponse) { + console.info('using fallback cached response...', fallbackResponse.url) + return fallbackResponse + } } // when even the fallback response is not available,