From d2a9c7772460eeb7aa4e47720c96a77568e0e128 Mon Sep 17 00:00:00 2001
From: Ayo <ramon.aycojr@gmail.com>
Date: Tue, 4 Oct 2022 14:30:00 +0200
Subject: [PATCH] chore: update project command scripts

---
 CONTRIBUTING.md                                      |  7 ++-----
 README.md                                            |  8 +++++++-
 demo/README.md                                       |  2 +-
 package.json                                         |  2 ++
 packages/astro-reactive-form/Form.astro              |  4 ++--
 packages/astro-reactive-form/test/Form.astro.test.js | 12 ++++++++----
 packages/astro-reactive-validator/package.json       |  3 ---
 7 files changed, 22 insertions(+), 16 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 1f3e0b4..9ababae 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -57,7 +57,7 @@ npm i
 4. Run the demo application
 
 ```
-npm run dev
+npm start
 ```
 
 5. Open the demo application on you browser. Browse to the address:
@@ -69,11 +69,8 @@ https://localhost:3000
 # Running package tests
 
 Please run the tests before creating a PR to make sure nothing is broken.
-
-Since we only have one package for now, this is the command to run:
-
 ```
-npm run test -w astro-reactive-form
+npm test
 ```
 
 # Hacking with the packages
diff --git a/README.md b/README.md
index 8044e89..744e1a6 100644
--- a/README.md
+++ b/README.md
@@ -49,7 +49,7 @@ npm i
 4. Run the demo application
 
 ```
-npm run dev
+npm start
 ```
 
 5. Open the demo application on you browser. Browse to the address:
@@ -58,6 +58,12 @@ npm run dev
 https://localhost:3000
 ```
 
+6. To run the tests:
+
+```
+npm test
+```
+
 _[Please report issues and suggestions](https://github.com/ayoayco/astro-reactive-library/issues)_
 
 # Contributors
diff --git a/demo/README.md b/demo/README.md
index 9f80750..39d1d49 100644
--- a/demo/README.md
+++ b/demo/README.md
@@ -3,4 +3,4 @@
 To start the app:
 
 1. `npm i`
-1. `npm run dev`
+1. `npm start`
diff --git a/package.json b/package.json
index ee6ba5c..b004b6b 100644
--- a/package.json
+++ b/package.json
@@ -14,6 +14,8 @@
     ".": "./index.ts"
   },
   "scripts": {
+    "start": "npm run dev -w demo",
+    "test": "npm run test --workspaces --if-present",
     "dev": "npm run dev -w demo",
     "bump-patch": "npm version patch -w",
     "bump-minor": "npm version minor -w",
diff --git a/packages/astro-reactive-form/Form.astro b/packages/astro-reactive-form/Form.astro
index 07972d5..a4e3fbb 100644
--- a/packages/astro-reactive-form/Form.astro
+++ b/packages/astro-reactive-form/Form.astro
@@ -15,7 +15,7 @@ const { formGroups } = Astro.props;
 <style>
 	.light {
 		/**
-		* run dev server with: "npm run dev",
+		* run dev server with: "npm start",
 		* then open browser to "localhost:3000"
 		* add a class="light" to the <form> element above to test changes
 		* INSERT STYLES FOR LIGHT MODE BELOW: */
@@ -23,7 +23,7 @@ const { formGroups } = Astro.props;
 
 	.dark {
 		/**
-		* run dev server with: "npm run dev",
+		* run dev server with: "npm start",
 		* then open browser to "localhost:3000"
 		* add a class="dark" to the <form> element above to test changes
 		* INSERT STYLES FOR DARK MODE BELOW: */
diff --git a/packages/astro-reactive-form/test/Form.astro.test.js b/packages/astro-reactive-form/test/Form.astro.test.js
index 22cd394..bb3945e 100644
--- a/packages/astro-reactive-form/test/Form.astro.test.js
+++ b/packages/astro-reactive-form/test/Form.astro.test.js
@@ -11,28 +11,32 @@ describe('Form.astro test', () => {
 	describe('INPUT: formGroups', () => {
 		it('Should handle undefined formGroups prop', async () => {
 			// arrange
-			const expectedResult = '<form></form>'
+			const expectedCount = 0;
+			const element = /<fieldset>/g;
 			const props = { formGroups: undefined };
 			component = await getComponentOutput('./Form.astro', props);
 
 			// act
 			const actualResult = cleanString(component.html);
+			const matches = actualResult.match(element) || [];
 
 			// assert
-			expect(actualResult).to.contain(expectedResult);
+			expect(matches.length).to.equal(expectedCount);
 		});
 
 		it('Should handle empty formGroups prop', async () => {
 			// arrange
-			const expectedResult = '<form></form>'
+			const expectedCount = 0;
+			const element = /<fieldset>/g;
 			const props = { formGroups: [] };
 			component = await getComponentOutput('./Form.astro', props);
 
 			// act
 			const actualResult = cleanString(component.html);
+			const matches = actualResult.match(element) || [];
 
 			// assert
-			expect(actualResult).to.contain(expectedResult);
+			expect(matches.length).to.equal(expectedCount);
 		});
 
 		it('Should render a fieldset for each form group', async () => {
diff --git a/packages/astro-reactive-validator/package.json b/packages/astro-reactive-validator/package.json
index 59c1b90..200ecc6 100644
--- a/packages/astro-reactive-validator/package.json
+++ b/packages/astro-reactive-validator/package.json
@@ -9,9 +9,6 @@
   },
   "main": "index.js",
   "devDependencies": {},
-  "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
-  },
   "repository": {
     "type": "git",
     "url": "git+https://github.com/ayoayco/astro-reactive-library.git"